Merge pull request #320 from jerrrren/jerren-DG-update

Jerren dg update

docs/DeveloperGuide.md

@@ -621,7 +621,7 @@ Sequence Diagram:
 ##### Flow
 
 1. The user types and enters the command `aelr eid/1 s/2022-03-04 e/2022-03-06` where 1 is the employee id, 2022-03-04 is the start date and 2022-03-06 is the end date.
-2. The parser checks that the end date `e/` is after the start date represented by `s/`.The end date `e/` also must be less than 7 days away from the start date `s/`. If both conditions are not satisfied, an error message will be shown.
+2. The parser checks that the end date `e/` is not before the start date represented by `s/`.The end date `e/` also must be less than 7 days away from the start date `s/`. If both conditions are not satisfied, an error message will be shown.
 3. The parser would instantiate a `Id` constructed from the input of argument `eid/` and a list of `LeaveDate` objects representing every single day in the range between `s/` and `e/` with the end and start dates inclusive.
 4. The `Id` and list of `LeaveDate` are passed down to the newly created command.
 5. The command is executed. The command first tries to find the `Employee` with ID 1. If the `Employee` does not exist, an error message will be displayed.

docs/diagrams/commands/leaves/AddEmployeeToLeave.puml

@@ -47,25 +47,12 @@ destroy AddEmployeeToLeaveCommandParser
 SudoHrParser --> LogicManager : a
 deactivate SudoHrParser
 
-LogicManager -> AddEmployeeToLeaveCommand : execute()
+LogicManager -> AddEmployeeToLeaveCommand : execute(model)
 activate AddEmployeeToLeaveCommand
 
 AddEmployeeToLeaveCommand -> Model : addEmployeeToLeave(1,2022-03-04)
 activate Model
 
-Model --> AddEmployeeToLeaveCommand
-deactivate Model
-
-AddEmployeeToLeaveCommand -> Model : updateFilteredEmployeeList
-activate Model
-
-Model --> AddEmployeeToLeaveCommand
-deactivate Model
-
-AddEmployeeToLeaveCommand -> Model : updateFilteredLeaveList
-activate Model
-
-
 Model --> AddEmployeeToLeaveCommand
 deactivate Model
 

docs/diagrams/commands/leaves/AddEmployeeToLeaveFromTo.puml

@@ -45,7 +45,7 @@ destroy AddEmployeeToLeaveFromToCommandParser
 SudoHrParser --> LogicManager : a
 deactivate SudoHrParser
 
-LogicManager -> AddEmployeeToLeaveFromToCommand : execute()
+LogicManager -> AddEmployeeToLeaveFromToCommand : execute(model)
 activate AddEmployeeToLeaveFromToCommand
 
 loop 4 times
@@ -56,19 +56,6 @@ Model --> AddEmployeeToLeaveFromToCommand
 deactivate Model
 end
 
-AddEmployeeToLeaveFromToCommand -> Model : updateFilteredEmployeeList
-activate Model
-
-Model --> AddEmployeeToLeaveFromToCommand
-deactivate Model
-
-AddEmployeeToLeaveFromToCommand -> Model : updateFilteredLeaveList
-activate Model
-
-
-Model --> AddEmployeeToLeaveFromToCommand
-deactivate Model
-
 create CommandResult
 AddEmployeeToLeaveFromToCommand -> CommandResult
 activate CommandResult

docs/diagrams/commands/leaves/DeleteEmployeeFromLeave.puml

@@ -45,25 +45,13 @@ destroy DeleteEmployeeFromLeaveCommandParser
 SudoHrParser --> LogicManager : d
 deactivate SudoHrParser
 
-LogicManager -> DeleteEmployeeFromLeaveCommand : execute()
+LogicManager -> DeleteEmployeeFromLeaveCommand : execute(model)
 activate DeleteEmployeeFromLeaveCommand
 
 DeleteEmployeeFromLeaveCommand -> Model : deleteEmployeeFromLeave(1,2022-03-04)
 activate Model
 
 
-Model --> DeleteEmployeeFromLeaveCommand
-deactivate Model
-
-DeleteEmployeeFromLeaveCommand -> Model : updateFilteredEmployeeList
-activate Model
-
-Model --> DeleteEmployeeFromLeaveCommand
-deactivate Model
-
-DeleteEmployeeFromLeaveCommand -> Model : updateFilteredLeaveList
-activate Model
-
 Model --> DeleteEmployeeFromLeaveCommand
 deactivate Model