Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CS2113-T13-1]-iamabhishek98-ChangedNamingTasksConvention #369

Merged
merged 11 commits into from
Nov 11, 2019
Merged

[CS2113-T13-1]-iamabhishek98-ChangedNamingTasksConvention #369

merged 11 commits into from
Nov 11, 2019

Conversation

iamabhishek98
Copy link
Collaborator

@iamabhishek98 iamabhishek98 added this to the v1.4 milestone Nov 11, 2019
@iamabhishek98 iamabhishek98 self-assigned this Nov 11, 2019
Lucria
Lucria previously approved these changes Nov 11, 2019
View reviewed changes
@Lucria
Copy link

Lucria commented Nov 11, 2019

Merge after fixing the import code quality issue

sinteary
sinteary approved these changes Nov 11, 2019
View reviewed changes
Copy link

@sinteary sinteary left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! But please check and update the UG on the adocs later!

@sinteary sinteary merged commit 1dad82b into AY1920S1-CS2113-T13-1:master Nov 11, 2019
@nus-pe-script nus-pe-script mentioned this pull request Nov 14, 2019
Open
19 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sinteary sinteary sinteary approved these changes

@Lucria Lucria Lucria left review comments

Assignees

@iamabhishek98 iamabhishek98

Labels
None yet
Projects
None yet
Milestone
v1.4
Development

Successfully merging this pull request may close these issues.

Inconsistent naming for certain flags
3 participants
@iamabhishek98 @Lucria @sinteary