Adding adhomf clients #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
afink-aveva
reviewed
Jan 17, 2025
afink-aveva
reviewed
Jan 17, 2025
| if type(omf_message) is not bytes: | ||
| compressed_body = self.compressOMFMessage(omf_message) | ||
| else: | ||
| if omf_message[0] == 31 and omf_message[1] == 139: |
There was a problem hiding this comment.
Since this is a "magic number" check, adding a comment here or maybe even better moving the byte checking logic to a function like IsGzipFormat() would make this more readable
There was a problem hiding this comment.
I saw this comment was resolved but I don't see any change associated with it. Was this addressed?
afink-aveva
approved these changes
Jan 17, 2025
fabiodani5450
approved these changes
Jan 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.