prevent alt menu for firefox

[light-and-ray]

Description

Firefox opens menu bar in the top of window "File, Edit, View, etc" by default. It can be disabled by https://support.mozilla.org/en-US/questions/1278533. But I think it's better to just prevent defaults for alt key at all

Screenshots/videos:

Checklist:

• I have read contributing wiki page
• I have performed a self-review of my own code
• My code follows the style guidelines
• My code passes tests

[AUTOMATIC1111]

This is unrelated to webui and should be handled by firefox extensions.

[light-and-ray]

Why? Many web apps block this behavior because it's default for firefox. And what did you mean by firefox extensions?

[AUTOMATIC1111]

This applies globally to firefox, not to web ui. What you need is a firefox extension that will disable this globally.

[light-and-ray]

Not truth, it applies only for webui tab. E.g. photopea does the same. Look my patch, it just prevents default for alt

fdhggfhg.mp4

[light-and-ray]

I think it's very nessasary patch because it breaks zooming with default alt key. It cancels after uping alt key

dfsg.mp4

[AUTOMATIC1111]

Can anyone else confirm this? For me, alt+mouse wheel works fine in Firefox 123.0.1 (64-bit).

[light-and-ray]

Hm, maybe in windows it's disabled by default? Which variable have been set in about:config -> menuAccessKeyFocuses. I had this problem right after I started using the webui. And it appears on 2 devices

[AUTOMATIC1111]

The key is true for me, but the menu is also always visible. The File menu gets focused when I release alt, but it does not interfere with zooming.

[light-and-ray]

It because in your case there is no resize event

[AUTOMATIC1111]

I can reproduce the problem now, after removing the menu, but disabling entire alt key because of just zoom is not right. Plus, wouldn't the code as it is now fail if you hold alt, press another key, release another key, then release alt?

[light-and-ray]

disabling entire alt key because of just zoom is not right

I don't think so. I think it's okay to override browser's defaults for webapp

But it's your choice. How I can apply this event listner only for image box? Maybe add event lisner on targetElement instead of document

Plus, wouldn't the code as it is now fail if you hold alt, press another key, release another key, then release alt?

No, I tested it, and have retested it again. If I press something after alt, and then release alt, the menu isn't opened even on other pages

[light-and-ray]

Made it, now alt is being suppressed only if the key in config is "Alt" and mouse was inside image

There is one problem, if you press alt outside image, then move mouse inside, and start zooming, menu will appear. But I think nobody presses alt before move mouse inside image

[AUTOMATIC1111]

Is it not possible to check for e.code in the release event?

[light-and-ray]

Yes, it can fix it. I forget about it. Pushed
keydown event is still needed for case alt was pressed inside zone, but released outside, what is a popular scenario