Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Official LCM Sampler Support #14583

Merged

Conversation

continue-revolution
Copy link
Contributor

@continue-revolution continue-revolution commented Jan 8, 2024

Description

This is official LCM sampler support. "Official" means that code has been reviewd by LCM author @luosiallen and LyCORIS author @KohakuBlueleaf

Checklist:

@AUTOMATIC1111 AUTOMATIC1111 merged commit 751d014 into AUTOMATIC1111:dev Jan 9, 2024
3 checks passed
@continue-revolution continue-revolution deleted the conrevo/lcm-sampler branch January 9, 2024 16:38
@AUTOMATIC1111
Copy link
Owner

There should also be some way to convey to user that the lora is needed for this properly function. Maybe a warning message in the outputs (like the ones you get when you use a lora you don't have).

@KohakuBlueleaf
Copy link
Collaborator

There should also be some way to convey to user that the lora is needed for this properly function. Maybe a warning message in the outputs (like the ones you get when you use a lora you don't have).

I have tried LCM without LCM lora and it could actually generate some normal images
I think it is fine?

@light-and-ray
Copy link
Contributor

There should also be some way to convey to user that the lora is needed for this properly function. Maybe a warning message in the outputs (like the ones you get when you use a lora you don't have).

It can be used with checkpoints with merged lcm lora, and it also works with sd_turbo

@continue-revolution
Copy link
Contributor Author

continue-revolution commented Jan 10, 2024

It's challenging to verify whether or not user is using LCM LoRA. If we can verify in some way, then I tend to do things in this way

  • if user is using this sampler, we check if user is using LCM LoRA
  • if user is using LCM LoRA, we check if user is specifying a low CFG scale

One way to do so is to verify if the LoRA's name contains substring "lcm", but I'm not sure if this is a proper way.

@light-and-ray
Copy link
Contributor

I think it was bad idea

@KohakuBlueleaf
Copy link
Collaborator

I think the best way is to add some kind of optional warning section
This will be good since we may add more features which only works if you enable/use some specific resources. Or some feature that is intended for specific hardware or whatever like that

@w-e-w w-e-w mentioned this pull request Feb 17, 2024
@George0726
Copy link

Hi guys, it would be great to extend the LCM sampler to TCM sampler,
https://mhh0318.github.io/tcd/

@pawel665j pawel665j mentioned this pull request Apr 16, 2024
@lalala-233
Copy link

lalala-233 commented Apr 26, 2024

Hi guys, it would be great to extend the LCM sampler to TCM sampler,
https://mhh0318.github.io/tcd/

That's good, but it's called TCD (

@bigmover
Copy link

There should also be some way to convey to user that the lora is needed for this properly function. Maybe a warning message in the outputs (like the ones you get when you use a lora you don't have).

It can be used with checkpoints with merged lcm lora, and it also works with sd_turbo

hi @

There should also be some way to convey to user that the lora is needed for this properly function. Maybe a warning message in the outputs (like the ones you get when you use a lora you don't have).

It can be used with checkpoints with merged lcm lora, and it also works with sd_turbo

Hi @continue-revolution This is great! LCM-lora is available for use with controlnet?

@continue-revolution
Copy link
Contributor Author

@bigmover should be fine with any combination (no error on your terminal) but the performance will require your own experiments

@bigmover
Copy link

@bigmover should be fine with any combination (no error on your terminal) but the performance will require your own experiments

@continue-revolution Thanks very much for your prompt reply! I mean if controlnet use the same steps with SD base model, perhaps will have an influence on the quality on image. May I ask if there are any related suggestions or ideas?

@continue-revolution
Copy link
Contributor Author

@bigmover Various experiments (ControlNet + AnimateDiff) show that you do not have to worry about this

@bigmover
Copy link

There should also be some way to convey to user that the lora is needed for this properly function. Maybe a warning message in the outputs (like the ones you get when you use a lora you don't have).

I have tried LCM without LCM lora and it could actually generate some normal images I think it is fine?

You mean that low CFG and low steps is ok on the quality of image? Besides whether newer TCD whill be supported?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants