Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: use file structs #22

Merged
merged 5 commits into from
Jul 16, 2024
Merged

refactor: use file structs #22

merged 5 commits into from
Jul 16, 2024

Conversation

tensorush
Copy link
Contributor

@tensorush tensorush commented Jul 15, 2024

  • made use of file structs to avoid redundant namespaces
  • added the simple_spacecraft_orientation to run with other examples in build.zig
  • consider using doctests, I only changed the CelestialBody one to demonstrate.

@ATTron
Copy link
Owner

ATTron commented Jul 15, 2024

thanks for this! I will get to this today and look it over ⭐

@ATTron
Copy link
Owner

ATTron commented Jul 16, 2024

This all looks good to me! I might go back at some point and switch Ecs back to EquatorialCoordinateSystem, just for me I like having the full names of things when I can. If there is some zig style guide opinions about this I will defer to them, but my own personal preference is to have the full name be the structs name

@tensorush
Copy link
Contributor Author

tensorush commented Jul 16, 2024

Sure, I think long names are fine, I changed it back. My reasoning was that it seemed the odd one out as it's comprised of 3 pretty long words, so I chose to use its acronym in code, while still having the full words in the top-level comment of its file struct definition.

@ATTron ATTron merged commit 2170cbe into ATTron:main Jul 16, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants