Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug ad index mordred #389

Closed
wants to merge 3 commits into from
Closed

Bug ad index mordred #389

wants to merge 3 commits into from

Conversation

paulsonak
Copy link
Collaborator

To fix AD index calculation on mordred features that contain NaN's #388

@paulsonak paulsonak requested a review from mcloughlin2 January 17, 2025 00:44
Copy link

codecov bot commented Jan 17, 2025

Codecov Report

Attention: Patch coverage is 11.11111% with 48 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
atomsci/ddm/pipeline/compare_models.py 0.00% 43 Missing ⚠️
atomsci/ddm/pipeline/model_pipeline.py 50.00% 3 Missing ⚠️
atomsci/ddm/pipeline/model_datasets.py 60.00% 2 Missing ⚠️
@@            Coverage Diff             @@
##            1.7.0     #389      +/-   ##
==========================================
+ Coverage   28.53%   29.84%   +1.30%     
==========================================
  Files          47       47              
  Lines       12919    13813     +894     
==========================================
+ Hits         3687     4123     +436     
- Misses       9232     9690     +458     
Files with missing lines Coverage Δ
atomsci/ddm/pipeline/model_datasets.py 60.39% <60.00%> (-0.48%) ⬇️
atomsci/ddm/pipeline/model_pipeline.py 40.13% <50.00%> (-3.42%) ⬇️
atomsci/ddm/pipeline/compare_models.py 5.58% <0.00%> (-0.07%) ⬇️

... and 4 files with indirect coverage changes

@paulsonak paulsonak closed this Jan 17, 2025
@paulsonak
Copy link
Collaborator Author

wrong commits

@paulsonak paulsonak deleted the bug_AD_index_mordred branch January 21, 2025 22:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant