chore: upgrade Spoon to 10.0.1-beta-2
#676
Conversation
…ly look up the path of mvn executable" This reverts commit 2f7125e.
| <profile> | ||
| <id>spoonSnapshot</id> | ||
| <repositories> | ||
| <repository> | ||
| <id>ow2.org-snapshot</id> | ||
| <name>Maven Repository for Spoon Snapshots</name> | ||
| <url>https://repository.ow2.org/nexus/content/repositories/snapshots/</url> | ||
| <snapshots><enabled>true</enabled></snapshots> | ||
| </repository> | ||
| </repositories> | ||
| </profile> |
There was a problem hiding this comment.
I removed this XML config because it was not working for fetching SNAPSHOTs of Spoon when I was trying to debug Sorald using it. For using SNAPSHOT version, we can refer how it is done in diffmin because I know it works there.
There was a problem hiding this comment.
You don't want to do it like it is in diffmin, because that adds a repository to anything that depends on diffmin. In general, one should avoid adding repositories in pom files, here's a pretty good article about it.
Putting the repository in a profile means that it won't be included by default in dependent libraries/applications, which is desirable. As a concrete example of why it's bad to put repositories in pom files (without putting them in custom profiles): the old snapshot repository we used for Spoon was in its pom file, and it was pretty unreliable and went down every now and then. And every time it did, it wasn't possible to build Spoon or anything depending on Spoon, as that repository couldn't be reached. Even though nothing was fetched from it.
This works perfectly if you activate spoonSnapshot profile, e.g. mvn -P spoonSnapshot compile, but by default the repository isn't included (which is what we want).
There was a problem hiding this comment.
I did not know this. Thanks!
I was about to argue that it is still safe to enclose SNAPSHOT URLs in repositories however, sorald is also used as a dependency in some other projects, eg. repairnator. So I get your point. I will revert this change whenever we need the SNAPSHOT version next time.
There was a problem hiding this comment.
I will revert this change whenever we need the SNAPSHOT version next time.
@algomaster99 Do you think we should open an issue not to forget this? Or should we do it right now?
There was a problem hiding this comment.
I don't think so opening an issue is necessary because it is not needed and whenever we want to work with the SNAPSHOT version again, we will know what we have to do. :)
algomaster99
force-pushed
the
upgrade-spoon-10.0.1-beta-2
branch
4 times, most recently
from
e3cfb91 to
f3b0280
Compare
This comment has been minimized.
This comment has been minimized.
algomaster99
force-pushed
the
upgrade-spoon-10.0.1-beta-2
branch
from
a3d1936 to
395a18c
Compare
algomaster99
force-pushed
the
upgrade-spoon-10.0.1-beta-2
branch
from
395a18c to
76c1e5b
Compare
|
@khaes-kth Let's wait for tests to turn green and then I think we can merge this. |
We are upgrading the version of Spoon to this beta release because it has fixes to our high priority bugs and a workaround. I will push tests for all of them in this PR becasue they all are contingent upon the version upgrade. Moreover, it won't make the PR huge and difficult to review.
Bugs
Workaround