-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: store excluded references in a set which wraps IdentityHashMap
#611
refactor: store excluded references in a set which wraps IdentityHashMap
#611
Conversation
IdentityHashMap
I am not sure what went wrong here, because tests passed on my machine. @khaes-kth could you please re-run the workflow? I think the failure could be because of the flaky tests. |
@algomaster99 The scheduled builds on master have been failing for a few days, it's probably not related to this PR. |
I did it, but it seems the problem isn't fix with a rerun. @fermadeiral @monperrus : can you add @algomaster99 as a collaborator so that he can see the logs? It seems I do not have access to do it. |
Aman and you now have role "maintainer".
|
The scheduled builds are failing as pointed out by Simon. I have created a PR to fix it, but it seems like that isn't the best way. |
The tests should pass here after #617 is merged. |
@khaes-kth once all tests are green, you may proceed to merge. This PR just refactors the code and it doesn't fix anything. |
@khaes-kth ping for merge. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Reference #602
I thought I would refactor the code first as suggested by @slarse.