Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, our most common error is a missing
eo:cloud_cover
property in the STAC item.From close inspection, it looks like we should be using
landsat:cloud_cover_land
:eo:cloud_cover
appears to be missing for items where the cloud % was not calculated (CLOUD_COVER = -1
in the product metadata), but the corrospondinglandsat:cloud_cover_land
does appear to exists with a value of -1 in these cases.TODOs:
<=
comparison being used and the -1 values aren't handled specially:https://github.com/nasa-jpl/its_live_production/blob/main/src/tools/missingpairstools/find_all_USGS_Collection2_imagepairs_for_jsoncatalogs.py#L266