Upgrade to Flask v3 #2484
Merged
Upgrade to Flask v3 #2484
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jtherrmann
added
the
bumpless
jtherrmann
temporarily deployed
to
hyp3-multi-burst-sandbox
GitHub Actions
Inactive
jtherrmann
temporarily deployed
to
hyp3-multi-burst-sandbox
GitHub Actions
Inactive
jtherrmann
removed
the
bumpless
jacquelynsmale
approved these changes
Nov 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
We recently started seeing a ton of failing tests like this:
which originate from an old version of Flask (see this commit for example).
For some reason, dependabot has not been opening PRs to upgrade Flask. I can only think this must be because the PyPI package is named
Flaskbut our requirements file specifiedflask(lowercase).This PR bumps to the latest version of
Flask, which fixes thewerkzeug-related test failures but introduces 8 new failing tests. Skimming the failures, it looks like this may just be some data type mismatches in expected HTTP responses, so will probably just involve identifying why we're seeing those mismatches and then updating the types in either the code or the tests.Additional notes
In addition to the changes listed in the Changelog, this PR also updates three API unit tests so that we don't use
Decimalvalues in the expected API responses. This wasn't causing any test failures, but it brings the tests closer to reality because those values are serialized to eitherintorfloatin the JSON responses.TODO