-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Per-job Instance Types and AMIs #2390
Conversation
Looking ahead, we'll be moving ARIA S1 GUNW (INSAR_ISCE) jobs into production HyP3 soon, which are currently running on the C or M instance family (we found them to be the most cost-optimal). So, I think this approach is better overall as we'll have broader needs than just GPU vs CPU.
Right now, we do cost control by limiting the max vcpus, which works well with one compute environment. Multiple compute environments will definitely reduce the effectiveness of this strategy. For the LAVAs deployment, I don't think we'll be using the EDC cost controls, so won't matter there. We can side-step the cost control worry in EDC by keeping it a single compute environment there for now, but we'll need to tackle it when we bring in GUNWs if we want to use the C/M instance families. I'm not sure how forward-looking we want to be overall here, but we definitely don't want to put ourselves in a corner later. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like these are just extra blank lines, not a trailing newline.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All of the code changes look good, but I still want to render the templates locally and review the changes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I also confirmed that none of our existing CF resources have been renamed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've confirmed that the templates render locally as expected.
The snyk failure is unrelated to this PR. |
No description provided.