Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Access codes for automatic user approval #2285

Merged
merged 28 commits into from
May 23, 2024
Merged

Access codes for automatic user approval #2285

merged 28 commits into from
May 23, 2024

Conversation

jtherrmann
Copy link
Contributor

@jtherrmann jtherrmann commented May 20, 2024 •
edited
Loading

Other changes not listed in the Changelog:

  • Remove the default_credits parameter from the dynamo.user._reset_credits_if_needed function
  • Add a dynamo.util.current_utc_time function

TODO:

  • Add/update tests
    • apps/api/src/hyp3_api/handlers.py: patch_user
    • lib/dynamo/dynamo/user.py: update_user
  • Validate changes in sandbox deployment
  • TODOs in code
  • Changelog

@jtherrmann jtherrmann temporarily deployed to hyp3-whitelisting-sandbox May 20, 2024 22:13 — with GitHub Actions Inactive
@jtherrmann jtherrmann temporarily deployed to hyp3-whitelisting-sandbox May 20, 2024 22:43 — with GitHub Actions Inactive
@jtherrmann jtherrmann temporarily deployed to hyp3-whitelisting-sandbox May 22, 2024 17:25 — with GitHub Actions Inactive
@jtherrmann jtherrmann temporarily deployed to hyp3-whitelisting-sandbox May 22, 2024 21:15 — with GitHub Actions Inactive
@jtherrmann jtherrmann marked this pull request as ready for review May 22, 2024 22:00
@jtherrmann jtherrmann requested a review from a team May 22, 2024 22:00
@jtherrmann jtherrmann temporarily deployed to hyp3-whitelisting-sandbox May 22, 2024 22:03 — with GitHub Actions Inactive
forrestfwilliams
forrestfwilliams reviewed May 23, 2024
View reviewed changes
apps/api/src/hyp3_api/api-spec/openapi-spec.yml.j2 Outdated Show resolved Hide resolved
lib/dynamo/dynamo/user.py Outdated Show resolved Hide resolved
lib/dynamo/dynamo/user.py Show resolved Hide resolved
tests/test_api/test_patch_user.py Show resolved Hide resolved
lib/dynamo/dynamo/util.py Outdated Show resolved Hide resolved
@jtherrmann jtherrmann temporarily deployed to hyp3-whitelisting-sandbox May 23, 2024 20:59 — with GitHub Actions Inactive
@jtherrmann jtherrmann merged commit 0a5e957 into develop May 23, 2024
12 checks passed
@jtherrmann jtherrmann deleted the access-codes branch May 23, 2024 21:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@forrestfwilliams forrestfwilliams forrestfwilliams approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jtherrmann @forrestfwilliams