Make flood-depth-estimator nullable #1640
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jhkennedy
approved these changes
May 23, 2023
There was a problem hiding this comment.
@jacquelynsmale yes, this is precisely the change I was going to circle back to make and was specifically what I was worried about. Thanks!
jacquelynsmale
added
bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Started the ball rolling on how to make the
flood-depth-estimatorvalue functionally nullable inWATER_MAPandWATER_MAP_TEST. The current implementation will not acceptnullas valid and gets"status": 400, "title": "Bad Request".@jhkennedy I didn't know what your thoughts were, but I started by just enumerating null. Open to any and all other ideas!