Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Water mask documentation page #430

Merged
merged 15 commits into from
Mar 21, 2024
Merged

Water mask documentation page #430

merged 15 commits into from
Mar 21, 2024

Conversation

hjkristenson
Copy link
Contributor

This PR adds a documentation page to the SAR Basics section describing the new water mask being used for InSAR processing. It also includes references to the subpackage in the asf_tools Python package for generating this mask, and lists the public bucket where the reference mask is stored.

@hjkristenson hjkristenson added the patch Bump the patch version number of this project label Mar 20, 2024
docs/water_masking.md Outdated Show resolved Hide resolved
jtherrmann
jtherrmann previously approved these changes Mar 21, 2024
Copy link
Contributor

@jtherrmann jtherrmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, apart from my nitpicks / questions, which you're free to ignore if they're not relevant.

@jtherrmann
Copy link
Contributor

I rendered the changes locally and verified there are no broken links.

Copy link
Contributor

@forrestfwilliams forrestfwilliams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved, but as @jtherrmann noted I think we should change the title to "Water Masking"

docs/water_masking.md Outdated Show resolved Hide resolved
docs/water_masking.md Show resolved Hide resolved
Copy link
Contributor

@jtherrmann jtherrmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Re-re-approved :)

Edit: Darn @forrestfwilliams beat me

@hjkristenson hjkristenson merged commit 17bf0e4 into develop Mar 21, 2024
5 checks passed
@hjkristenson hjkristenson deleted the watermask branch March 21, 2024 17:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
patch Bump the patch version number of this project
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants