Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add the merge burst insar products section in the burst_insar_product_guide.md #413

Merged
merged 12 commits into from
Feb 12, 2024

Conversation

cirrusasf
Copy link
Contributor

No description provided.

@cirrusasf cirrusasf requested a review from a team February 6, 2024 01:42
Copy link
Contributor

@jacquelynsmale jacquelynsmale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly small stuff but a couple of areas where I was confused as to where the ordering of things was.
Mainly, I wanted to know

  • How you wanted to format the 'Options'. Are they their own subsections
  • What does the first 'Options' section pertain to? Can you link more documentation there?
  • It generally seems that code values and snippets should be indicated as such with markdown, so I went and suggested those changes. I don't know how necessary that is

@cirrusasf cirrusasf added the patch Bump the patch version number of this project label Feb 8, 2024
Copy link
Contributor Author

@cirrusasf cirrusasf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it looks good to me.

Copy link
Contributor Author

@cirrusasf cirrusasf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the additions to describe the files as input of merge workflow and the merge product packaging.

The product packaging of merged burst InSAR products follows the same conventions outlined in [Product Packaging](#product-packaging "Jump to the Product Packaging section of this document") section above with two exceptions. First, the four range-doppler images are not included since the products have already been merged. Second, the product is modified slightly; the Burst ID is swapped for the zero-padded relative orbit number, and the swath number are removed. The resulting format is:
```
S1_rrr__yyymmdd_yyymmdd_pp_INTn_uuuu
```
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need to list the file names in the merge product as a table and also give the example filenames just like in Table 2 ?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cirrusasf I can see the logic in this, but I don't think we should. Adding a second table would add a ton of duplication to the product guide and I think we're better off just referencing the product packaging section like we've done here.

@forrestfwilliams forrestfwilliams merged commit 7205b65 into develop Feb 12, 2024
5 checks passed
@forrestfwilliams forrestfwilliams deleted the add_merge_bursts_docs branch February 12, 2024 18:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
patch Bump the patch version number of this project
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants