Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add support for velocity mosaics from granule stacks without a common reference date #57
base: develop
Are you sure you want to change the base?
add support for velocity mosaics from granule stacks without a common reference date #57
Changes from 3 commits
c4b31e5
6add683
2a200e4
2b16f4d
a6bcec7
d4145fc
8e25ea7
df22d19
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When this function is called we're not currently guaranteed to have all granules between two dates. For example, if we're trying to get velocity between
date1
anddate5
, there might be granules like:date1_date2
,date1_date3
date3_date4
,date4_date5
but calling
find_needed_granules
here with theminmax
strategy would only loaddate1_date3
, anddate4_date5
.Two possible ways to accomplish this:
align_to_common_reference_date
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The two core use cases I see brewing have been:
For a particular frame...
I suspect these are also the data-preparation steps data users will need to do for most analysis using this data set. I'm somewhat eager to revisit
find_needed_granules
,update_reference_date
, andalign_to_common_reference_date
to provide a better interface for those two more generic use cases.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I suppose the latter time-series approach satisfies all use cases, but when you only care about total change the former approach would be faster and require less data access.