Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove dispose from dugite watcher #41

Merged
merged 1 commit into from
Dec 19, 2019
Merged

Remove dispose from dugite watcher #41

merged 1 commit into from
Dec 19, 2019

Conversation

arekzaluski
Copy link

@arekzaluski arekzaluski commented Dec 17, 2019 •
edited
Loading

What it does

How to test

Review checklist

Reminder for reviewers

westbury
westbury approved these changes Dec 19, 2019
View reviewed changes
Copy link

@westbury westbury left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I'll be sure not to cherry-pick this into our release-0.12.0 branch as it is already fixed there.

@westbury westbury merged commit 326eee5 into release-0.9.0 Dec 19, 2019
@westbury westbury deleted the fix-scm-unwatch-crash branch December 19, 2019 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@westbury westbury westbury approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@arekzaluski @westbury