Implemented Hg.createBranch() and removed Hg.checkout() after hg.createBranch() call. #36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
westbury
approved these changes
Nov 13, 2019
| */ | ||
| createBranch(repository: Repository, branchName: string, branchStartPoint?: string): Promise<void> | ||
| createBranch(repository: Repository, branchName: string): Promise<void> |
There was a problem hiding this comment.
Thanks for removing the parameter. It makes no sense in Mercurial.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it does
Hg.createBranch()(commandhg branch).Hg.checkout()afterHg.createBranch(), the newly created branch is already active (and anywaycheckoutneeds acommitbefore selecting a new branch from remote).Note: It uses
hg branch <name>without-fthen the branch name must be unique.How to test
Review checklist
Reminder for reviewers