IOTIDE 2157: hg forget operation replaced with discard #35
Conversation
Signed-off-by: Federico Bozzini <[email protected]>
Signed-off-by: Federico Bozzini <[email protected]>
Signed-off-by: Federico Bozzini <[email protected]>
| registerResourceAction('1_modification', { | ||
| commandId: HG_COMMANDS.DISCARD.id, | ||
| when: 'scmProvider == hg && scmResourceGroup == changed' | ||
| }); |
There was a problem hiding this comment.
Surely if we support 'discard' but do not support 'forget' then we should be doing it the same way as Git. I.e. the user should delete the file first (typically in the Navigator). There is no equivalent in Git to 'forget' (in the case where it applies to a committed file), and as files without changes do not show up in the Source Control view, such actions would have to be available in the navigator. I think this change is ok, but I just want to be sure because I know Joe wants things to work the same in Git and Hg where it makes sense to treat them the same.
There was a problem hiding this comment.
With this change the forget action is completely removed, so, if I understand correctly what you mean, the interface should be the same you get on Git.
There was a problem hiding this comment.
Yes, I see now the Git implementation deletes the file if it's not in the index, so we are fine.
What it does
hg forget operation replaced with discard
How to test
Edit a tracked file. Instead of the
forgetoperation,discardis shown.Review checklist
Reminder for reviewers