Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add MAX32670 #15263

Merged
merged 13 commits into from
Apr 20, 2022
Merged

Add MAX32670 #15263

merged 13 commits into from
Apr 20, 2022

Conversation

ozersa
Copy link
Contributor

@ozersa ozersa commented Apr 13, 2022

Summary of changes

Add MAX32670EVKIT board support.

Impact of changes

Migration actions required

Documentation

https://os.mbed.com/platforms/MAX32670EVKIT/

Pull request type 

[] Patch update (Bug fix / Target update / Docs update / Test update / Refactor)
[] Feature update (New feature / Functionality change / New API)
[] Major update (Breaking change E.g. Return code change / API behaviour change)

Test results 

[] No Tests required for this change (E.g docs only update)
[] Covered by existing mbed-os tests (Greentea or Unittest)
[X] Tests / results supplied as part of this PR

MAX32670EVKIT_TestResult_20220408_ARMC6.txt
MAX32670EVKIT_TestResult_20220408_GCC_ARM.txt

Reviewers

Sadik.Ozer added 12 commits April 8, 2022 10:40
Add initial version of files
028a85c 
Signed-off-by: Sadik.Ozer <[email protected]>
Update cmsis files
fc90e9a 
Signed-off-by: Sadik.Ozer <[email protected]>
Remove __R because of confliction
f40887a 
Signed-off-by: Sadik.Ozer <[email protected]>
Add peripheral interface files
704bfc7 
Signed-off-by: Sadik.Ozer <[email protected]>
Add peripheral driver files
8a2681b 
Signed-off-by: Sadik.Ozer <[email protected]>
Fix rtc read issue
65e6595 
Signed-off-by: Sadik.Ozer <[email protected]>
Provide all uart mapping
f1bce73 
Signed-off-by: Sadik.Ozer <[email protected]>
Provide option to user to drive SS pin too
24f4738 
Signed-off-by: Sadik.Ozer <[email protected]>
Leave last page of flash
9298365 
It is used by rom bootloader

Signed-off-by: Sadik.Ozer <[email protected]>
Update LP API
7826582 
Signed-off-by: Sadik.Ozer <[email protected]>
Update system files and mbed wrappers
2f813fc 
Signed-off-by: Sadik.Ozer <[email protected]>
Fix GCC_ARM warnings
8323e9a 
Signed-off-by: Sadik.Ozer <[email protected]>
@ciarmcom ciarmcom requested review from a team April 13, 2022 08:00
@ciarmcom
Copy link
Member

@ozersa, thank you for your changes.
@ARMmbed/team-maximintegrated @ARMmbed/mbed-os-maintainers please review.

ahmetalincak
ahmetalincak approved these changes Apr 13, 2022
View reviewed changes
Copy link

@ahmetalincak ahmetalincak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

utf-8 check
4dd0144 
Signed-off-by: Sadik.Ozer <[email protected]>
@0xc0170
Copy link
Contributor

0xc0170 commented Apr 19, 2022

CI started

@mergify mergify bot added needs: CI and removed needs: review labels Apr 19, 2022
@mbed-ci
Copy link

mbed-ci commented Apr 19, 2022

Jenkins CI Test : ✔️ SUCCESS

Build Number: 1 | 🔒 Jenkins CI Job | 🌐 Logs & Artifacts

CLICK for Detailed Summary

jobs Status
jenkins-ci/mbed-os-ci_build-cloud-example-ARM ✔️
jenkins-ci/mbed-os-ci_build-cloud-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_unittests ✔️
jenkins-ci/mbed-os-ci_build-greentea-ARM ✔️
jenkins-ci/mbed-os-ci_build-greentea-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_build-example-ARM ✔️
jenkins-ci/mbed-os-ci_build-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_greentea-test ✔️

@0xc0170 0xc0170 merged commit 47a32a0 into ARMmbed:master Apr 20, 2022
@mergify mergify bot removed the ready for merge label Apr 20, 2022
@mergify
Copy link

mergify bot commented Apr 20, 2022

This PR does not contain release version label after merging.

@mergify mergify bot added the release version missing When PR does not contain release version, bot should label it and we fix it afterwards label Apr 20, 2022
@0xc0170 0xc0170 added release-type: patch Indentifies a PR as containing just a patch and removed release version missing When PR does not contain release version, bot should label it and we fix it afterwards labels Apr 20, 2022
@0xc0170
Copy link
Contributor

0xc0170 commented Apr 20, 2022

This PR does not contain release version label after merging.

Fixed

@mbedmain mbedmain added release-version: 6.16.0 Release-pending and removed release-type: patch Indentifies a PR as containing just a patch Release-pending labels Jun 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0xc0170 0xc0170 0xc0170 approved these changes

@ahmetalincak ahmetalincak ahmetalincak approved these changes

Assignees
No one assigned
Labels
devices: maxim release-version: 6.16.0 scope: new-target
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@ozersa @ciarmcom @0xc0170 @mbed-ci @ahmetalincak @mbedmain