Make gpio irq api portable #15190
Merged
Make gpio irq api portable #15190
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ciarmcom
added
the
release-type: patch
|
@hazzlim, thank you for your changes. |
ciarmcom
added
needs: review
devices: toshiba
component: core
devices: gigadevice
devices: nxp
devices: cypress
devices: nordic
devices: maxim
devices: nuvoton
devices: sparkfun
component: hal
devices: st
devices: silicon labs
devices: arm
devices: analog devices
component: test
devices: samsung
devices: renesas
labels
jeromecoutant
approved these changes
Dec 10, 2021
0xc0170
previously approved these changes
Dec 16, 2021
|
Ci started |
Maybe worth holding off merging before review from @ARMmbed/mbed-os-hal (?) |
Jenkins CI Test : ❌ FAILEDBuild Number: 1 | 🔒 Jenkins CI Job | 🌐 Logs & ArtifactsCLICK for Detailed Summary
|
|
I just wanted to give it a first go with CI if it finds anything. It failed (one target gpio test timeout) |
hazzlim
force-pushed
the
make_gpio_irq_api_portable
branch
from
37491e5 to
fccedda
Compare
I've re-run the failed test and it passed, looks like it was an issue with connecting to the board rather than with the changes. Oddly though, looks like on the original CI run the test in question ( |
ithinuel
approved these changes
Jan 26, 2022
|
CI restarted |
Jenkins CI Test : ❌ FAILEDBuild Number: 4 | 🔒 Jenkins CI Job | 🌐 Logs & ArtifactsCLICK for Detailed Summary
|
Sorry, there's new targets added since I originally opened this which need updating as well. Will update. |
The HAL gpio_irq_api stores object IDs, which serve as a form of context for the dispatch of the interrupt handler in the drivers level InterruptIn Class. The way this is achieved is that the InterruptIn Class casts its address to uint32_t, which is stored as the ID. This results in compilation failure when the size of an object pointer is greater than uint32_t, for example when building on a PC for unit testing. In order to allow Unit Testing of the InterruptIn Class, we replace the use of uint32_t with uintptr_t (type capable of holding a pointer), which allows portability and expresses intentions more clearly. In aid of this latter goal, we also replace the use of the name "id" with "context", to improve clarity - these are addresses of the context related to that callback.
hazzlim
force-pushed
the
make_gpio_irq_api_portable
branch
from
fccedda to
f4e5359
Compare
Have updated with changes for new target (TOSHIBA TMPM4KN). |
ithinuel
approved these changes
Jan 26, 2022
|
CI started |
Jenkins CI Test : ✔️ SUCCESSBuild Number: 5 | 🔒 Jenkins CI Job | 🌐 Logs & ArtifactsCLICK for Detailed Summary
|
0xc0170
approved these changes
Jan 31, 2022
mbedmain
added
release-version: 6.16.0
Release-pending
and removed
release-type: patch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
This PR makes similar changes to that of #15077 for the purpose of building MbedOS drivers components for unit testing.
Impact of changes
Migration actions required
Documentation
Pull request type
Test results
Reviewers
@ARMmbed/mbed-os-core @ARMmbed/mbed-os-hal