Move connectivity netsocket stubs #14873
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ciarmcom
added
the
release-type: patch
|
@rajkan01, thank you for your changes. |
rajkan01
force-pushed
the
move_connectivity_netsocket_stubs
branch
from
4350eb7 to
d44d119
Compare
|
CI started |
Jenkins CI Test : ✔️ SUCCESSBuild Number: 1 | 🔒 Jenkins CI Job | 🌐 Logs & ArtifactsCLICK for Detailed Summary
|
|
This PR cannot be merged due to conflicts. Please rebase to resolve them. |
Move the connectivity netsocket stubs into the connectivity/netsocket component directory. So we can avoid duplicating the mbed-os source tree in a central UNITTESTS folder.
Update netsocket and cellular unit tests to link with a mbed-stubs-netsocket library that it depends on instead of link with mbed-stubs which is a group of stubs libraries.
- Previously, all netsocket headers made as a part of the mbed-headers-connectivity library. To make it easier to separate all the netsocket headers into the separate mbed-headers-netsocket library and keep them, as part of netsocket stubs CMake. This makes the netsocket stubs more self-contained and improves the composition of the library. - Update cellular, netsocket unit tests to link only with a mbed-headers-netsocket library that it depends on instead of link with mbed-headers which is a group of headers libraries.
Previously all the netsocket stubs headers under mbed-stubs-headers, so this PR move all netsocket stubs headers under netsocket/tests/UNITTESTS/double directory and update CMake to include stubs headers into mbed-stubs-netsocket library to make netsocket stubs to be self-contained.
rajkan01
force-pushed
the
move_connectivity_netsocket_stubs
branch
from
d44d119 to
ef0e3f9
Compare
|
@0xc0170 I have re-based this PR, could you review and start the CI |
|
Ci restarted |
Jenkins CI Test : ✔️ SUCCESSBuild Number: 2 | 🔒 Jenkins CI Job | 🌐 Logs & ArtifactsCLICK for Detailed Summary
|
paul-szczepanek-arm
approved these changes
Jul 7, 2021
| @@ -28,8 +28,10 @@ target_sources(${TEST_NAME} | |||
| target_link_libraries(${TEST_NAME} | |||
| PRIVATE | |||
| mbed-headers | |||
| mbed-headers-netsocket | |||
There was a problem hiding this comment.
this is not included in mbed-headers?
There was a problem hiding this comment.
We will fix this part of #14879 issue
pan-
approved these changes
Jul 7, 2021
0xc0170
approved these changes
Jul 7, 2021
mbedmain
added
release-version: 6.13.0
Release-pending
and removed
release-type: patch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
fixes #14839
mbed-stubs-headers, so this PR move all netsocket stubs headers undernetsocket/tests/UNITTESTS/doubledirectory and update CMake to include those headers as part of mbed-stubs-netsocketImpact of changes
None.
Migration actions required
None
Documentation
To be updated
Pull request type
Test results
Reviewers