Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move stubs cellular headers #14835

Merged
merged 1 commit into from
Jul 7, 2021
Merged

Move stubs cellular headers #14835

merged 1 commit into from
Jul 7, 2021

Conversation

rajkan01
Copy link
Contributor

@rajkan01 rajkan01 commented Jun 28, 2021

Summary of changes

fixes #14794

  • Previously all the stubs headers under mbed-stubs-headers, so this PR move all cellular stubs headers under cellular/tests/UNITTESTS/double directory and update CMake to include headers into mbed-stubs-cellular library to make cellular stubs to be self-contained

Impact of changes

None.

Migration actions required

None

Documentation

To be updated


Pull request type

[x] Patch update (Bug fix / Target update / Docs update / Test update / Refactor)
[] Feature update (New feature / Functionality change / New API)
[] Major update (Breaking change E.g. Return code change / API behaviour change)

Test results

[] No Tests required for this change (E.g docs only update)
[x] Covered by existing mbed-os tests (Greentea or Unittest)
[] Tests / results supplied as part of this PR

Reviewers


@ciarmcom ciarmcom added the release-type: patch Indentifies a PR as containing just a patch label Jun 28, 2021
@ciarmcom ciarmcom requested a review from a team June 28, 2021 11:00
@ciarmcom
Copy link
Member

@rajkan01, thank you for your changes.
@ARMmbed/mbed-os-maintainers please review.

LDong-Arm
LDong-Arm previously approved these changes Jun 29, 2021
@mergify
Copy link

mergify bot commented Jun 30, 2021

This PR cannot be merged due to conflicts. Please rebase to resolve them.

@mergify mergify bot removed the needs: CI label Jun 30, 2021
@rajkan01 rajkan01 force-pushed the move_stubs_cellular_headers branch from eb1327c to e96debd Compare June 30, 2021 10:47
@mergify mergify bot dismissed LDong-Arm’s stale review June 30, 2021 10:47

Pull request has been modified.

@mergify
Copy link

mergify bot commented Jun 30, 2021

This PR cannot be merged due to conflicts. Please rebase to resolve them.

@rajkan01 rajkan01 force-pushed the move_stubs_cellular_headers branch from e96debd to ad48cf4 Compare July 2, 2021 13:27
LDong-Arm
LDong-Arm previously approved these changes Jul 2, 2021
Copy link
Contributor

@LDong-Arm LDong-Arm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

…ble dir

Previously all the stubs headers under mbed-stubs-headers,
so this PR move all cellular stubs headers under
cellular/tests/UNITTESTS/double directory and update CMake
to include headers into mbed-stubs-cellular library to make
cellular stubs to be self-contained
@rajkan01 rajkan01 force-pushed the move_stubs_cellular_headers branch from ad48cf4 to a60869d Compare July 2, 2021 13:30
@mergify mergify bot dismissed LDong-Arm’s stale review July 2, 2021 13:31

Pull request has been modified.

@rajkan01 rajkan01 requested a review from LDong-Arm July 2, 2021 13:33
@mergify mergify bot added needs: CI and removed needs: work labels Jul 2, 2021
@ciarmcom
Copy link
Member

ciarmcom commented Jul 5, 2021

This pull request has automatically been marked as stale because it has had no recent activity. @ARMmbed/mbed-os-maintainers, please start CI to get the PR merged.

@ciarmcom ciarmcom added the stale Stale Pull Request label Jul 5, 2021
@0xc0170
Copy link
Contributor

0xc0170 commented Jul 6, 2021

CI started

@mbed-ci
Copy link

mbed-ci commented Jul 6, 2021

Jenkins CI Test : ✔️ SUCCESS

Build Number: 1 | 🔒 Jenkins CI Job | 🌐 Logs & Artifacts

CLICK for Detailed Summary

jobs Status
jenkins-ci/mbed-os-ci_unittests ✔️

@0xc0170 0xc0170 removed the stale Stale Pull Request label Jul 7, 2021
@0xc0170 0xc0170 merged commit fea4e92 into master Jul 7, 2021
@mergify mergify bot removed the ready for merge label Jul 7, 2021
@mbedmain mbedmain added release-version: 6.13.0 Release-pending and removed release-type: patch Indentifies a PR as containing just a patch Release-pending labels Jul 14, 2021
@0xc0170 0xc0170 deleted the move_stubs_cellular_headers branch October 5, 2021 08:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Move cellular stubs to Connectivity/cellular directory
6 participants