Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[mbed-os-5.15] Add system time read/write callbacks to mbed-mesh-api #14818

Merged
merged 2 commits into from
Jul 15, 2021
Merged

[mbed-os-5.15] Add system time read/write callbacks to mbed-mesh-api #14818

merged 2 commits into from
Jul 15, 2021

Conversation

artokin
Copy link
Contributor

@artokin artokin commented Jun 23, 2021

Summary of changes

Add system time read/write callbacks to mbed-mesh-api. Nanostack will use the callbacks for system time synchronisation in the mesh network.

This is a copy of #14754

Impact of changes

Migration actions required

Documentation

Pull request type 

[x] Patch update (Bug fix / Target update / Docs update / Test update / Refactor)
[] Feature update (New feature / Functionality change / New API)
[] Major update (Breaking change E.g. Return code change / API behaviour change)

Test results 

[] No Tests required for this change (E.g docs only update)
[x] Covered by existing mbed-os tests (Greentea or Unittest)
[] Tests / results supplied as part of this PR

Reviewers

@mikter , @mikaleppanen , @juhhei01 @JarkkoPaso

Arto Kinnunen and others added 2 commits June 23, 2021 14:22
System time read/write callbacks (ARMmbed#2637)
bad78ee 
- Add new API for setting system time read and write callbacks.
- Update ws_pae to use the new time service.
Enable nanostack system time read/write
4fe7842 
Allow Nanostack to read and write system time to synchronise time in
the mesh network. By default feature is enabled in the mesh json-
configuration.
@ciarmcom ciarmcom requested review from JarkkoPaso, juhhei01, mikaleppanen, mikter and a team June 23, 2021 11:30
@ciarmcom
Copy link
Member

@artokin, thank you for your changes.
@JarkkoPaso @mikaleppanen @mikter @juhhei01 @ARMmbed/mbed-os-maintainers please review.

@mergify mergify bot added needs: CI and removed needs: review labels Jun 24, 2021
@0xc0170
Copy link
Contributor

0xc0170 commented Jun 24, 2021

CI started

@mbed-ci
Copy link

mbed-ci commented Jun 24, 2021

Test run: SUCCESS

Summary: 10 of 10 test jobs passed
Build number : 1
Build artifacts

@0xc0170 0xc0170 requested a review from andypowers June 24, 2021 12:39
andypowers
andypowers reviewed Jul 14, 2021
View reviewed changes
Copy link
Collaborator

@andypowers andypowers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved.

@0xc0170 0xc0170 merged commit 4f89cbb into ARMmbed:mbed-os-5.15 Jul 15, 2021
@mergify mergify bot removed the ready for merge label Jul 15, 2021
@artokin artokin deleted the add_nanostack_system_time_callbacks_to_5_15 branch August 24, 2021 12:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andypowers andypowers andypowers left review comments

@0xc0170 0xc0170 0xc0170 approved these changes

@JarkkoPaso JarkkoPaso Awaiting requested review from JarkkoPaso

@juhhei01 juhhei01 Awaiting requested review from juhhei01

@mikaleppanen mikaleppanen Awaiting requested review from mikaleppanen

@mikter mikter Awaiting requested review from mikter

Assignees
No one assigned
Labels
release-version: 5.15.8
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@artokin @ciarmcom @0xc0170 @mbed-ci @JarkkoPaso @andypowers