mbedtls: Rename Mbed timing implementation #14760
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ciarmcom
added
the
release-type: patch
|
@Patater, thank you for your changes. |
rwalton-arm
reviewed
Jun 10, 2021
We get a linker warning with the recently added timing module
implementation for Mbed. This is because there is Mbed TLS also ships a
file called timing.c, which we are including in Mbed OS also. With CLI
1, we get an error about unique object files because of the similarly
named implementation files.
Object file timing.o is not unique! It could be made from: mbed-os/connectivity/mbedtls/source/timing.c mbed-os/connectivity/mbedtls/platform/src/timing.cpp
Rename the Mbed timing module implementation to timing_mbed.cpp to avoid
this naming conflict.
Fixes: b8781e5 ("mbedtls: Add an alt implementation of timing")
Fixes ARMmbed#14759
Patater
force-pushed
the
tls-timing-alt-fix
branch
from
286adb2 to
87d1992
Compare
rwalton-arm
approved these changes
Jun 10, 2021
|
CI started |
Jenkins CI Test : ✔️ SUCCESSBuild Number: 1 | 🔒 Jenkins CI Job | 🌐 Logs & ArtifactsCLICK for Detailed Summary
|
0xc0170
approved these changes
Jun 10, 2021
|
I marked this as ready for CI, waiting for Travis to be restored |
|
I'll reopen in 2-3 minutes, that should restart Travis |
mergify
bot
removed
component: security
needs: CI
release-type: patch
0xc0170
added
component: security
needs: CI
release-type: patch
mbedmain
added
release-version: 6.12.0
Release-pending
and removed
release-type: patch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
We get a linker warning with the recently added timing module
implementation for Mbed. This is because there is Mbed TLS also ships a
file called timing.c, which we are including in Mbed OS also. With CLI
1, we get an error about unique object files because of the similarly
named implementation files.
Rename the Mbed timing module implementation to timing_alt.cpp to avoid
this naming conflict.
Fixes: b8781e5 ("mbedtls: Add an alt implementation of timing")
Fixes #14759
Impact of changes
None
Migration actions required
None
Documentation
None
Pull request type
Test results
Reviewers