Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test examples: remove tls socket, it was deprecated some time ago #14744

Merged
merged 1 commit into from
Jun 9, 2021
Merged

test examples: remove tls socket, it was deprecated some time ago #14744

merged 1 commit into from
Jun 9, 2021

Conversation

0xc0170
Copy link
Contributor

@0xc0170 0xc0170 commented Jun 8, 2021

Summary of changes

The example was deprecated some time ago. We should not test it in CI for 5.15 branch (it was removed from master).

Impact of changes

Migration actions required

Documentation

Pull request type 

[x] Patch update (Bug fix / Target update / Docs update / Test update / Refactor)
[] Feature update (New feature / Functionality change / New API)
[] Major update (Breaking change E.g. Return code change / API behaviour change)

Test results 

[x] No Tests required for this change (E.g docs only update)
[] Covered by existing mbed-os tests (Greentea or Unittest)
[] Tests / results supplied as part of this PR

Reviewers

@ciarmcom
Copy link
Member

ciarmcom commented Jun 8, 2021

@0xc0170, thank you for your changes.
@ARMmbed/mbed-os-maintainers please review.

@ciarmcom ciarmcom requested a review from a team June 8, 2021 10:30
@ciarmcom
Copy link
Member

ciarmcom commented Jun 8, 2021

@0xc0170, thank you for your changes.
@ARMmbed/mbed-os-maintainers please review.

@0xc0170 0xc0170 requested a review from andypowers June 8, 2021 12:13
@0xc0170
Copy link
Contributor Author

0xc0170 commented Jun 8, 2021

Travis failed, investigating the python pip error.

andypowers
andypowers approved these changes Jun 8, 2021
View reviewed changes
Copy link
Collaborator

@andypowers andypowers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved.

@0xc0170 0xc0170 closed this Jun 9, 2021
@0xc0170
Copy link
Contributor Author

0xc0170 commented Jun 9, 2021

I am not able to restart the job, I'll reopen. travis should be green here

@0xc0170 0xc0170 reopened this Jun 9, 2021
@mbed-ci
Copy link

mbed-ci commented Jun 9, 2021

Test run: SUCCESS

Summary: 10 of 10 test jobs passed
Build number : 1
Build artifacts

@0xc0170 0xc0170 merged commit 071c1b5 into ARMmbed:mbed-os-5.15 Jun 9, 2021
@mergify mergify bot removed the ready for merge label Jun 9, 2021
@0xc0170 0xc0170 deleted the mbed-os-5.15-remove-tls-example branch June 17, 2021 13:28
@artokin artokin mentioned this pull request Jun 21, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andypowers andypowers andypowers approved these changes

Assignees
No one assigned
Labels
release-version: 5.15.8
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@0xc0170 @ciarmcom @mbed-ci @andypowers