Add Link Loss Service #14
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paul-szczepanek-arm
requested changes
Nov 27, 2020
|
We need to decide on some common folder structure for the service files. @pan- @AGlass0fMilk ? |
noonfom
force-pushed
the
experimental-services
branch
from
fb1f2c9 to
ddc20f6
Compare
pan-
requested changes
Dec 1, 2020
noonfom
force-pushed
the
experimental-services
branch
from
ddc20f6 to
6eac2a4
Compare
paul-szczepanek-arm
requested changes
Dec 3, 2020
There was a problem hiding this comment.
Just a couple more issues and please add an mbed_lib.json, see:
#15
services/inc/LinkLossService.h
Outdated
| * The on_alert_requested() and on_alert_end() event handlers should be overridden | ||
| * by your application. For example, in the former case, you could alert the user by | ||
| * flashing lights, making noises, moving, etc. | ||
| * |
There was a problem hiding this comment.
Suggested change
| * | |
| * This service requires access to gap events. Please register a ChainableGapEventHandler with Gap and pass it to this service. |
| void LinkLossService::onDisconnectionComplete(const ble::DisconnectionCompleteEvent &event) | ||
| { | ||
| AlertLevel level = get_alert_level(); | ||
| if (_alert_handler != nullptr && event.getReason() == ble::disconnection_reason_t::CONNECTION_TIMEOUT && level != AlertLevel::NO_ALERT) { |
There was a problem hiding this comment.
Suggested change
| if (_alert_handler != nullptr && event.getReason() == ble::disconnection_reason_t::CONNECTION_TIMEOUT && level != AlertLevel::NO_ALERT) { | |
| if (_alert_handler != nullptr && event.getReason() == ble::disconnection_reason_t::CONNECTION_TIMEOUT && level != AlertLevel::NO_ALERT && !_in_alert) { |
| { | ||
| const uint8_t level = *write_request->data; | ||
|
|
||
| if (level <= *reinterpret_cast<uint8_t *>(AlertLevel::HIGH_ALERT)) { |
There was a problem hiding this comment.
Suggested change
| if (level <= *reinterpret_cast<uint8_t *>(AlertLevel::HIGH_ALERT)) { | |
| if (level <= static_cast<uint8_t>(AlertLevel::HIGH_ALERT)) { |
noonfom
force-pushed
the
experimental-services
branch
2 times, most recently
from
abe8dc4 to
4c3494f
Compare
noonfom
force-pushed
the
experimental-services
branch
from
e474742 to
8ee4f22
Compare
paul-szczepanek-arm
approved these changes
Dec 3, 2020
pan-
requested changes
Dec 7, 2020
|
|
||
| if (level <= (uint8_t)(AlertLevel::HIGH_ALERT)) { | ||
| set_alert_level((AlertLevel) level); | ||
| } |
There was a problem hiding this comment.
Could you return an error if the alert is out of range ?
pan-
approved these changes
Dec 8, 2020
noonfom
pushed a commit
to noonfom/mbed-os-experimental-ble-services
that referenced
this pull request
Dec 16, 2020
* Add Link Loss Service * Set auth reply if alert level is out of range
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Link Loss Service uses the Alert Level characteristic, as defined in the Bluetooth SIG Assigned Numbers, to cause an
alert in the device when the link is lost.
Reviewers
@pan-
@paul-szczepanek-arm