Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix using mixed APIs in Gattserver example #225

Merged
merged 2 commits into from
Mar 25, 2019
Merged

fix using mixed APIs in Gattserver example #225

merged 2 commits into from
Mar 25, 2019

Conversation

paul-szczepanek-arm
Copy link
Member

@paul-szczepanek-arm paul-szczepanek-arm commented Mar 22, 2019 •
edited
Loading

Update example to use the new API. No functional change.

pan-
pan- requested changes Mar 24, 2019
View reviewed changes
Copy link
Member

@pan- pan- left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

New functions doesn't return an error in case of failure which means initialisation continue. Why not keep advertising configuration in when_init_complete ?

@paul-szczepanek-arm
Copy link
Member Author

For simplicity, just like a failure at start_advertising() didn't stop the process either.

@paul-szczepanek-arm
Update BLEProcess.h
73bb488 
stop init on failure
@paul-szczepanek-arm
Copy link
Member Author

@pan- I addressed your review, please re-review

@pan- pan- merged commit c293192 into ARMmbed:master Mar 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pan- pan- pan- approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@paul-szczepanek-arm @pan-