Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Correct pip install help message on Mac #763

Merged
merged 3 commits into from
Sep 27, 2018
Merged

Correct pip install help message on Mac #763

merged 3 commits into from
Sep 27, 2018

Conversation

theotherjimmy
Copy link
Contributor

Fixes #654

@theotherjimmy
Copy link
Contributor Author

@screamerbg We were not using platform to do detection before. I don't recall if there was a reason not to. Do you remember if there was?

@theotherjimmy
Copy link
Contributor Author

@cmonr Review please.

@cmonr cmonr self-requested a review September 27, 2018 16:07
@cmonr
Copy link
Contributor

cmonr commented Sep 27, 2018

Instructions worked, even though the site timed out when I clicked on the sha 😄

@theotherjimmy
Copy link
Contributor Author

Instructions say Linux on mac. Fixing.

@screamerbg screamerbg self-requested a review September 27, 2018 16:51
screamerbg
screamerbg approved these changes Sep 27, 2018
View reviewed changes
Copy link
Contributor

@screamerbg screamerbg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@screamerbg screamerbg merged commit 2e0dc6a into ARMmbed:master Sep 27, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@screamerbg screamerbg screamerbg approved these changes

@cmonr cmonr cmonr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@theotherjimmy @cmonr @screamerbg