Skip to content

Commit

Permalink
Update default MRP config to match the spec (project-chip#23344)
Browse files Browse the repository at this point in the history
  • Loading branch information
vivien-apple authored and adbridge committed Nov 18, 2022
1 parent 039f064 commit ee35362
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 4 deletions.
2 changes: 1 addition & 1 deletion src/messaging/ReliableMessageProtocolConfig.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@ void ClearLocalMRPConfigOverride()
ReliableMessageProtocolConfig GetDefaultMRPConfig()
{
// Default MRP intervals are defined in spec <2.11.3. Parameters and Constants>
static constexpr const System::Clock::Milliseconds32 idleRetransTimeout = 4000_ms32;
static constexpr const System::Clock::Milliseconds32 idleRetransTimeout = 300_ms32;
static constexpr const System::Clock::Milliseconds32 activeRetransTimeout = 300_ms32;
return ReliableMessageProtocolConfig(idleRetransTimeout, activeRetransTimeout);
}
Expand Down
6 changes: 3 additions & 3 deletions src/messaging/ReliableMessageProtocolConfig.h
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ namespace chip {
* subsequent failures in milliseconds.
*
* This is the default value, that might be adjusted by end device depending on its
* needs (e.g. sleeping period) using Service Discovery TXT record CRA key.
* needs (e.g. sleeping period) using Service Discovery TXT record SAI key.
*
*/
#ifndef CHIP_CONFIG_MRP_LOCAL_ACTIVE_RETRY_INTERVAL
Expand All @@ -54,10 +54,10 @@ namespace chip {
* failure in milliseconds.
*
* This is the default value, that might be adjusted by end device depending on its
* needs (e.g. sleeping period) using Service Discovery TXT record CRI key.
* needs (e.g. sleeping period) using Service Discovery TXT record SII key.
*/
#ifndef CHIP_CONFIG_MRP_LOCAL_IDLE_RETRY_INTERVAL
#define CHIP_CONFIG_MRP_LOCAL_IDLE_RETRY_INTERVAL (5000_ms32)
#define CHIP_CONFIG_MRP_LOCAL_IDLE_RETRY_INTERVAL (300_ms32)
#endif // CHIP_CONFIG_MRP_LOCAL_IDLE_RETRY_INTERVAL

/**
Expand Down

0 comments on commit ee35362

Please sign in to comment.