Skip to content

Commit

Permalink
Change BLE notifications to indications for QPG (project-chip#23635)
Browse files Browse the repository at this point in the history
  • Loading branch information
dvdm-qorvo authored and adbridge committed Nov 17, 2022
1 parent c75b0a7 commit 392958d
Show file tree
Hide file tree
Showing 3 changed files with 5 additions and 5 deletions.
2 changes: 1 addition & 1 deletion .gitmodules
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@
[submodule "qpg_sdk"]
path = third_party/qpg_sdk/repo
url = https://github.com/Qorvo/QMatter
branch = v0.9.0.0-libs
branch = vlatest-libs
platforms = qpg
[submodule "zap"]
path = third_party/zap/repo
Expand Down
6 changes: 3 additions & 3 deletions src/platform/qpg/BLEManagerImpl.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -292,17 +292,17 @@ bool BLEManagerImpl::SendIndication(BLE_CONNECTION_OBJECT conId, const ChipBleUU
uint16_t dataLen = data->DataLength();

VerifyOrExit(IsSubscribed(conId), err = CHIP_ERROR_INVALID_ARGUMENT);
ChipLogDetail(DeviceLayer, "Sending notification for CHIPoBLE Client TX (con %u, len %u)", conId, dataLen);
ChipLogDetail(DeviceLayer, "Sending indication for CHIPoBLE Client TX (con %u, len %u)", conId, dataLen);

isRxHandle = UUIDsMatch(&chipUUID_CHIPoBLEChar_RX, charId);
cId = qvCHIP_BleGetHandle(isRxHandle);

qvCHIP_BleSendNotification(conId, cId, dataLen, data->Start());
qvCHIP_BleSendIndication(conId, cId, dataLen, data->Start());

exit:
if (err != CHIP_NO_ERROR)
{
ChipLogError(DeviceLayer, "BLEManagerImpl::SendNotification() failed: %s", ErrorStr(err));
ChipLogError(DeviceLayer, "BLEManagerImpl::SendIndication() failed: %s", ErrorStr(err));
return false;
}
return true;
Expand Down
2 changes: 1 addition & 1 deletion third_party/qpg_sdk/repo
Submodule repo updated 148 files

0 comments on commit 392958d

Please sign in to comment.