FIX: Elevation Angle for some products #925
Conversation
Many Nexrad Level 3 files have elevation angle defined by Halfword 30 of the product description block, but not all. (Elevation angle is not relevant for all products.) Added a list of products for which elevation angle is defined by Halfword 30 per Table V of the ICD. For products for which it is not defined added logic to return data as None.
|
Addresses Issue #923. |
|
@dcedgren Thanks again for another change. The only thing is the data too None. I wonder if there should be a warning of some sort. Without elevation data, plotting etc I don't think will no longer work. So I'm having a think on that one. |
|
@zssherman, I don't know what the trickle-down might be. Products without elevation angle should be able to be plotted as a PPI but would be undefined to be plotted as an RHI. None makes more sense to me, but if we need to change it to zero to avoid compatibility issues with other modules that seems ok, too. |
|
Yep! And thanks for the initiative! |
|
@zssherman this is something you can work on, right? Can you add a separate commit to this pull request? |
|
@dcedgren ofcourse, I'll except the PR and submit a separate commit. Thanks again for the PR! |
Many Nexrad Level 3 files have elevation angle defined by Halfword 30 of the product description block, but not all. (Elevation angle is not relevant for all products.)
Added a list of products for which elevation angle is defined by Halfword 30 per Table V of the ICD. For products for which it is not defined added logic to return data as None.