Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOC: Update to docs to use rtd theme and remove python 2 from docs. #893

Merged
merged 17 commits into from
Jan 30, 2020

Conversation

zssherman
Copy link
Collaborator

example2
example1

Still going to do minor edits.

@zssherman
Copy link
Collaborator Author

example3

@zssherman
Copy link
Collaborator Author

Still need to do some minor edits, so not merging yet.

@zssherman
Copy link
Collaborator Author

@rcjackson whenever you get time, know your busy with AMS. The docs now pass, but there are alot of warnings that I'm seeing. Not sure if you've seen these before?

@zssherman zssherman force-pushed the doc_rtd_enhancement branch from def8536 to 7d1a7d4 Compare January 15, 2020 23:59
@zssherman zssherman changed the title DOC: Update to docs to use rtd theme and remove. DOC: Update to docs to use rtd theme and remove python 2 from docs. Jan 20, 2020
@zssherman zssherman requested a review from rcjackson January 21, 2020 18:50
@rcjackson
Copy link
Collaborator

It looks like you have .rst files that are not being referenced to in the documentation. I would double check to ensure that you're not missing any of those modules.

@zssherman
Copy link
Collaborator Author

Hmm all the rst files seem to be there in the source and generated directory, which is why I'm a little lost.

@zssherman
Copy link
Collaborator Author

But the warning seems to be for every single file, which almost seems like a format issue or something, but not sure honestly.

Copy link
Collaborator

@rcjackson rcjackson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suspect this is the problem. I think it will not go further than one deep in the modules unless you have this set to 4.

.. toctree::
:maxdepth: 4
:maxdepth: 1
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's whining about this. Try setting it back to 4.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gotcha, will try that

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rcjackson Dang, sadly did not work.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you try to access one of those functions in the docs can you still get to it? I just would like to know how important these warnings actually are, so this will tell me.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah it seems I can navigate through all the functions and their attributes and everything are there. One thing I notices is params show up as gate_yarray instead of gate_y: array so wondering if the old docs all colons need a space removed from before the colon

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In PyDDA I only put a space after the colon, not before. So that might be causing it to not work with this theme. I recall we ran into something similar with ACT.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gotcha, I'll go through and change all of that.

@zssherman
Copy link
Collaborator Author

I thin this is almost done. Most if not all warnings are fixed, examples are up to date. The only thing I can't figure out is why the custom Py-ART exceptions are not documenting. My only guess is the _templates aren't designed for how those classes are set up.

@zssherman
Copy link
Collaborator Author

@rcjackson @scollis Think this is as good as I can get it, if you both want to review one last time.

@rcjackson
Copy link
Collaborator

From what you have showed me, this should be good to go.

@zssherman
Copy link
Collaborator Author

zssherman commented Jan 30, 2020

Cool, thanks @rcjackson merging.

@zssherman zssherman merged commit 8707d1d into ARM-DOE:master Jan 30, 2020
@zssherman zssherman deleted the doc_rtd_enhancement branch January 30, 2020 17:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants