Max cappi #1627
Closed
Max cappi #1627
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@mgrover1 Could you please take a look at these conflicts? I'm not quite sure how to resolve them. |
|
Sure! I can take a look here - thanks for putting this together 👍 |
|
@syedhamidali - this should resolve the merge conflicts 👍 |
|
@mgrover1 Thank you! |
|
@mgrover1 I'm unsure if these CI errors relate to my commits. Could you help clarify? |
mgrover1
requested changes
Aug 29, 2024
| radar = pyart.io.read_nexrad_archive("s3://" + file) | ||
|
|
||
| # Create a 3D grid | ||
| # mask out last 10 gates of each ray, this removes the "ring" around the radar. |
There was a problem hiding this comment.
Suggested change
| # mask out last 10 gates of each ray, this removes the "ring" around the radar. | |
| # Mask out last 10 gates of each ray, this removes the "ring" around the radar. |
| # mask out last 10 gates of each ray, this removes the "ring" around the radar. | ||
| radar.fields["reflectivity"]["data"][:, -10:] = np.ma.masked | ||
|
|
||
| # exclude masked gates from the gridding |
There was a problem hiding this comment.
Suggested change
| # exclude masked gates from the gridding | |
| # Exclude masked gates from the gridding |
| gatefilter.exclude_masked("reflectivity") | ||
| gatefilter.exclude_outside("reflectivity", 10, 80) | ||
|
|
||
| # perform Cartesian mapping, limit to the reflectivity field. |
There was a problem hiding this comment.
Suggested change
| # perform Cartesian mapping, limit to the reflectivity field. | |
| # Perform Cartesian mapping, limit to the reflectivity field. |
| ds.lon.encoding["_FillValue"] = None | ||
|
|
||
| # Grab original radar(s) name and number of radars used to make grid | ||
| ds.attrs["nradar"] = self.nradar |
There was a problem hiding this comment.
@syedhamidali - you are removing nradar here within the attributes which is causing tests to fail
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So, I have added the plot_maxcappi function to the gridmapdisplay, here is what it is supposed to do