MNT: Bring in recent changes from main to the 2.0 branch #1623
+13,695
−1,866
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* FIX: Add isinstance checks to improve linting * FIX: Update the installation instructions * FIX: Update python versions * FIX: Update master to main in contributors guide
* FIX: Add isinstance checks to improve linting * ADD: Add suite of new utilities to xradar accessor * ADD: Add new xradar tests
* FIX: Add isinstance checks to improve linting * ADD: Add support for gridding from the xradar object * FIX: Fix failing tests * FIX: Cleanup the type hinting * FIX: Use allclose instead of assert equal
* DOC: Add docs for xradar and Py-ART * DOC: Add docs on using xradar with Py-ART * FIX: Fix small bugs
* ADD: Add dealias example with xradar * Fix misspelling of velocities
* ADD: Add python 3.12 to ci and wheels * ADD: Add additional docs on updated python versions
* ENH: Update for column vertical profile subset * ENH: inclusion of column_vertical_profile * ENH: inclusion of column_vertical_profile and associated functions * ENH: Addition of tests for column_vertical_profile * ENH: Linting corrections to columnsect. used ruff * ENH: linting corrections to test_columnsect; used ruff * ENH: Pre-commit linting corrections * ENH: Pre-commit linting corrections * ENH: Further columnsect linting corrections * ENH: removal of trailing whitespace.. * ENH: testing why pre-commit is giving me linting issues * ENH: Requested Corrections * MNT: Few more docstring changes. * CI: Temporary pin python 3.11 until datattree does a release. * Remove python version pin * FIX: Upgrade the version of precommit linter * update python v --------- Co-authored-by: zssherman <[email protected]> Co-authored-by: Max Grover <[email protected]>
* FIX: Fix python version used in CI system * FIX: Fix incorrect arg in ci workflow * DEL: Remove pinning of libnetcdf
* ADD: Xarray to Py-ART Grid interface * FIX: Pre-commit hooks * DOC: Parameters for Xgrid * ADD: Close dataset to test_accessor --------- Co-authored-by: Robert Jackson <[email protected]>
* FIX: Fix python version used in CI system * FIX: Fix incorrect arg in ci workflow * DEL: Remove pinning of libnetcdf * FIX: Fix when sweep_name is an empty attribute * FIX: Add more robust check
* Create precip_rate.py * Update __init__.py * Create test_precip_rate.py * Update precip_rate.py * Linting formatting * Update test_precip_rate.py * Update test_precip_rate.py * Move functions and change math to numpy * Update formatting * Update formatting * FIX: Fix the testing suite to avoid nans --------- Co-authored-by: mgrover1 <[email protected]>
* Rename functions and variables to remove "convective-stratiform" We want to make this function more generic so it can be used on a wide variety of fields and not just to detect convective and stratiform elements. I renamed most of the functions and some of the variables to reflect this and hopefully make it easier to use. * Add new reference * Incorporate binary closing option to functions * Add author to functions * Slight reformat for linting * More linting formatting * Add alternate option for getting under/over estimate field * Create plot_feature_detection.py * Delete plot_convective_stratiform.py * Update echo_class.py * Update plot_feature_detection.py * Update plot_feature_detection.py * Update test_echo_class.py * Keep original function and add warning * Revert "Delete plot_convective_stratiform.py" This reverts commit 2bff81a. * Update __init__.py * Update echo_class.py * Update dictionary keys * Update plot_convective_stratiform.py * Fix issues * Update plot_convective_stratiform.py
* FIX: change deprecated np.str in arm_vpt to str * Update default wind_size in calculate_velocity_texture from 4 to 3 Using an odd number prevents single index offsets in placement in case of an even size * ADD: optional rectangular window dims for velocity texture analysis. Also, modify the default window size to 3 instead of the previous value of 4 (even number resulting in a potential offset). * FIX: nyquist velocity dtype in radar obj loaded with read_kazr * pep8 * line reformatting per black * TST: unit tests for rectangular texture window * STY: linting (black) * FIX: Add in linting fixes * FIX: metadata in core.radar.get_elevation --------- Co-authored-by: mgrover1 <[email protected]>
* FIX: change deprecated np.str in arm_vpt to str * Update default wind_size in calculate_velocity_texture from 4 to 3 Using an odd number prevents single index offsets in placement in case of an even size * ADD: optional rectangular window dims for velocity texture analysis. Also, modify the default window size to 3 instead of the previous value of 4 (even number resulting in a potential offset). * FIX: nyquist velocity dtype in radar obj loaded with read_kazr * pep8 * line reformatting per black * TST: unit tests for rectangular texture window * STY: linting (black) * FIX: Add in linting fixes * FIX: metadata in core.radar.get_elevation * FIX: outdated text in masking_data_with_gatefilters.ipynb --------- Co-authored-by: mgrover1 <[email protected]>
* FIX: change deprecated np.str in arm_vpt to str * Update default wind_size in calculate_velocity_texture from 4 to 3 Using an odd number prevents single index offsets in placement in case of an even size * ADD: optional rectangular window dims for velocity texture analysis. Also, modify the default window size to 3 instead of the previous value of 4 (even number resulting in a potential offset). * FIX: nyquist velocity dtype in radar obj loaded with read_kazr * pep8 * line reformatting per black * TST: unit tests for rectangular texture window * STY: linting (black) * FIX: Add in linting fixes * FIX: metadata in core.radar.get_elevation * FIX: outdated text in masking_data_with_gatefilters.ipynb * ADD: method to automatically determine sweep number and sweep start and end indices * add comment to 'determine_sweeps' method * FIX: indexing bug in 'determine_sweeps' method * ADD: unit tests for 'determine_sweeps' * linting * FIX: nsweeps wasn't updated when calling 'determine_sweeps'; tests were updated accordingly * line reformatting per black * FIX: update multiple radar object attributes to ensure its full utilization with Py-ART after 'determine_sweeps' is called * line reformatting per black * linting * ENH: add antenna_transition to the testing module's sample objects * ENH: update unit tests to reflect antenna_transition allocation in sample_objects * Update pyart/util/radar_utils.py Co-authored-by: Max Grover <[email protected]> * Update pyart/util/radar_utils.py Co-authored-by: Max Grover <[email protected]> --------- Co-authored-by: mgrover1 <[email protected]>
* Update rainbow_wrl.py Prevent program from crashing when bins changes between sweeps. * ADD: Add new properties for _range in rainbow_wrl.py Add two properties, "meters_between_gates" and "meters_to_center_of_first_gate", required by the uf format file. * Update rainbow_wrl.py Raise error when range resolution changes between sweeps. * refactor: Fix linting * refactor: Fix linting
* ADD: _echo_class_wt.py: RadarEchoClass module with all methods/code from PyREClass. * ADD:wrapper function for wt_reclass * REFORMAT: Function names comply with PyART & PEP8 standards. * REFORMAT: Function names comply with PyART & PEP8 standards. * Revert "REFORMAT: Function names comply with PyART & PEP8 standards." This reverts commit 6ce7cc8. * REFORMAT: Function names comply with PyART & PEP8 standards. * ADD: masked array, detailed func arguments * MOD:func user arguments used,class num changed. * DOC:function and user arguments. * MOD: added metadata to field dictinery. * order of classes changed * cappi level added;better description of calsses * REFORMAT: PEP8 style * FORMAT:PEP8 * MOD:sanity check for conv core threshold * MOD:More sanity check for thresholds * MOD:Added override to sanity check+documentation * MOD:minor * invalid grid raises exception * first unit test added * ADD:func make_gaussian_storm_grid * ADD: test for output validity * ADD:utest for results of classification * ENH: test documentation and apply black formatting * ENH:small test func merged;name change * ADD: Stat-based tests for Gaussian storm grid function * ADD: example * FORMAT:Black * FIX: issues for #1495 the code review - aded TypeError handling in `_echo_class_wt.py` - Left tab docstring in `echo_class.py` - Added blank line in `_echo_class_wt.py` - Did not check `reflectivity_to_rainrate` function for duplication - Spellcheck Done - Confirmed grid object check in `echo_class.py` - Added `#noqa` comment in `__init__.py` * FIX:unused imports andvariables removed * Removed two line func sum_conv_wavelets(); * minor * Removed reflectivity_to_rainrate() * Test PAssed reflectivity_to_rainrate(): * minor:autosummary * ADD:conv_wavelet_sum() * Func Renamed: get_reclass -> wavelet_reclas * Refined documentation and Descriptive user arguments * FMT: Black * ENH:Docstring * DOC:Better description & ordering of classification categories * REFACTOR:scale_break now computed in calling function Moved scale break calculation to calling function, outputting scale_break as a parameter for the user. Adjusted related functions and variables. * ENH:scale_break is adaptive to resolution * ENH:atol added, tests default function arguments * FROMAT:black * MINOR:corrected tab in docstring * used new scaling and added description * MINOR: alignment in docstring * FORAMT:linting error corrected * 'LINTING ERR:import-block sorted;extra'()' removed' Follwing errors are fixed: pyart/retrieve/_echo_class_wt.py:192:26: UP034 [*] Avoid extraneous parentheses pyart/retrieve/echo_class.py:6:1: I001 [*] Import block is un-sorted or un-formatted Found 2 errors. [*] 2 fixable with the `--fix` option. Error: Process completed with exit code 1. * FIX: Fix linting error * FIX: Fix more linting errors * DOCS:minor docstrig chages from Zach * DOCS: testing precommit --------- Co-authored-by: mgrover1 <[email protected]> Co-authored-by: Max Grover <[email protected]>
* FIX: change deprecated np.str in arm_vpt to str * Update default wind_size in calculate_velocity_texture from 4 to 3 Using an odd number prevents single index offsets in placement in case of an even size * ADD: optional rectangular window dims for velocity texture analysis. Also, modify the default window size to 3 instead of the previous value of 4 (even number resulting in a potential offset). * FIX: nyquist velocity dtype in radar obj loaded with read_kazr * pep8 * line reformatting per black * TST: unit tests for rectangular texture window * STY: linting (black) * FIX: Add in linting fixes * FIX: metadata in core.radar.get_elevation * FIX: outdated text in masking_data_with_gatefilters.ipynb * ADD: method to automatically determine sweep number and sweep start and end indices * add comment to 'determine_sweeps' method * FIX: indexing bug in 'determine_sweeps' method * ADD: unit tests for 'determine_sweeps' * linting * FIX: nsweeps wasn't updated when calling 'determine_sweeps'; tests were updated accordingly * line reformatting per black * FIX: update multiple radar object attributes to ensure its full utilization with Py-ART after 'determine_sweeps' is called * line reformatting per black * linting * ENH: add antenna_transition to the testing module's sample objects * ENH: update unit tests to reflect antenna_transition allocation in sample_objects * Update pyart/util/radar_utils.py Co-authored-by: Max Grover <[email protected]> * Update pyart/util/radar_utils.py Co-authored-by: Max Grover <[email protected]> * ENH: add 'zdist_factor' input parameter to 'map_gates_to_grid'. This parameter scales the distance in the z-dimension when calculating weights upon gridding. It is a semi-equivalent to the scaling factors in the RoI class methods. Example for using this parameter would be setting a 'zdist_factor' value of 0.0 combined with an h_factor=0.0 (if calling DistBeamRoI) or z_factor=0.0 (if calling DistRoI), resulting in the exclusion of the z dimension in gridding weighting, which could serve as a potential solution for gridding a single PPI sweep from a single radar. In that case, the distance in the weighting function effectively serves as the distance of a given point from the PPI sweep's cone. * DEL: remove a redundant (liekly residual) input parameter (toa) from map_gates_to_grid * MNT: set a consistent nomenclature for the distance squared parameter. In parts of the 'map_grid' method it was referred to as 'dist' whereas in another as 'dist2' (parameter calculation lines differ in style but identical in value), resulting in an unnecessary scalar allocation, and a confusing nomenclature. * DOC: Add example for gridding data * Update pyart/map/gates_to_grid.py Co-authored-by: Max Grover <[email protected]> --------- Co-authored-by: mgrover1 <[email protected]>
* Create cfad.py * Update __init__.py * Create test_cfad.py * Create plot_cfad.py * Update plot_cfad.py * Update plot_feature_detection.py * Update cfad.py * Update test_cfad.py * Update plot_cfad.py * linting updates * linting update * Update to use grid or radar object * corrections * update example * Update test_cfad.py * Update test_cfad.py * Update test_cfad.py * add spaces --------- Co-authored-by: Zach Sherman <[email protected]>
Update the code quality actions
* ADD: Add a few lines to ci workflow to resolve issues * FIX: Stop caching downloads * ADD: Add open-radar-data pip install * FIX: Go back to caching * pin micromamba version * DEL: remove env name in ci * FIX: Move all packages to use conda-forge
#1660) * TST: Update test for windows builds. * MNT: Remove unused parameter. * FIX: Update with statement.
|
Did we want to close this one with the 2.0 conflicts fixed in the other PR? |
|
@zssherman - yeah, let's merge those in here! |
* Build(deps): Bump the actions group with 4 updates Bumps the actions group with 4 updates: [mamba-org/setup-micromamba](https://github.com/mamba-org/setup-micromamba), [codecov/codecov-action](https://github.com/codecov/codecov-action), [pypa/cibuildwheel](https://github.com/pypa/cibuildwheel) and [pypa/gh-action-pypi-publish](https://github.com/pypa/gh-action-pypi-publish). Updates `mamba-org/setup-micromamba` from 1 to 2 - [Release notes](https://github.com/mamba-org/setup-micromamba/releases) - [Commits](mamba-org/setup-micromamba@v1...v2) Updates `codecov/codecov-action` from 4.5.0 to 4.6.0 - [Release notes](https://github.com/codecov/codecov-action/releases) - [Changelog](https://github.com/codecov/codecov-action/blob/main/CHANGELOG.md) - [Commits](codecov/codecov-action@v4.5.0...v4.6.0) Updates `pypa/cibuildwheel` from 2.21.1 to 2.21.2 - [Release notes](https://github.com/pypa/cibuildwheel/releases) - [Changelog](https://github.com/pypa/cibuildwheel/blob/main/docs/changelog.md) - [Commits](pypa/cibuildwheel@v2.21.1...v2.21.2) Updates `pypa/gh-action-pypi-publish` from 1.10.2 to 1.10.3 - [Release notes](https://github.com/pypa/gh-action-pypi-publish/releases) - [Commits](pypa/gh-action-pypi-publish@v1.10.2...v1.10.3) --- updated-dependencies: - dependency-name: mamba-org/setup-micromamba dependency-type: direct:production update-type: version-update:semver-major dependency-group: actions - dependency-name: codecov/codecov-action dependency-type: direct:production update-type: version-update:semver-minor dependency-group: actions - dependency-name: pypa/cibuildwheel dependency-type: direct:production update-type: version-update:semver-patch dependency-group: actions - dependency-name: pypa/gh-action-pypi-publish dependency-type: direct:production update-type: version-update:semver-patch dependency-group: actions ... Signed-off-by: dependabot[bot] <[email protected]> * Update ci.yml --------- Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Max Grover <[email protected]>
…#1667) Bumps the actions group with 2 updates in the / directory: [mamba-org/setup-micromamba](https://github.com/mamba-org/setup-micromamba) and [pypa/cibuildwheel](https://github.com/pypa/cibuildwheel). Updates `mamba-org/setup-micromamba` from 1.9.0 to 2.0.0 - [Release notes](https://github.com/mamba-org/setup-micromamba/releases) - [Commits](mamba-org/setup-micromamba@v1.9.0...v2.0.0) Updates `pypa/cibuildwheel` from 2.21.2 to 2.21.3 - [Release notes](https://github.com/pypa/cibuildwheel/releases) - [Changelog](https://github.com/pypa/cibuildwheel/blob/main/docs/changelog.md) - [Commits](pypa/cibuildwheel@v2.21.2...v2.21.3) --- updated-dependencies: - dependency-name: mamba-org/setup-micromamba dependency-type: direct:production update-type: version-update:semver-major dependency-group: actions - dependency-name: pypa/cibuildwheel dependency-type: direct:production update-type: version-update:semver-patch dependency-group: actions ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* MNT: Remove pinning from requirements. * MNT: Remove pinning from environment file. * STY: PEP8 fixes. * STY: Fix for misordered imports. * STY: Revert old check. * CI: Update wheels.yml to use latest OS.
* ADD: Add dask to env * ADD: Add proper conda recipe * Update environment-ci.yml
* FIX: Updates code to fix scalar warnings. I fixed this by calling .items() to pull from the array. Also checks similar to radar utils if the arrays are 1 or more (mobile radar). * FIX: Forgot to check for singular radar later on.
* ADD: Add pygplk to ci system * ADD: Add gplk in pypi * STY: PEP8 fixes. * ADD: Add install glpk from conda * FIX: Fix name of glpk * FIX: Temporary pin on xarray until xradar release --------- Co-authored-by: Zach Sherman <[email protected]>
11 tasks
…1679) Bumps the actions group with 1 update: [pypa/gh-action-pypi-publish](https://github.com/pypa/gh-action-pypi-publish). Updates `pypa/gh-action-pypi-publish` from 1.10.3 to 1.11.0 - [Release notes](https://github.com/pypa/gh-action-pypi-publish/releases) - [Commits](pypa/gh-action-pypi-publish@v1.10.3...v1.11.0) --- updated-dependencies: - dependency-name: pypa/gh-action-pypi-publish dependency-type: direct:production update-type: version-update:semver-minor dependency-group: actions ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* FIX: Fix pinning of xradar and xarray * DEL: Remove the fixes in the CI/doc build * FIX: Ensure same dependencies in requirements and env files * DEP: Update workflows to use latest setup micromamba * FIX: Fix placement of version for mamba * FIX: Stop caching the doc env
…ray (#1681) * try to use datatree from xarray * FIX: Fix some small linting errors * FIX: Fix the import of register datatree accessor * DEP: Update dependencies to work with newer versions of xarray/xradar * FIX: Update CI to only run for 3.10+ * FIX: Fix bad version in requirements --------- Co-authored-by: Max Grover <[email protected]> Co-authored-by: mgrover1 <[email protected]>
In accordance with NEP/scientific python support, only support wheels for 3.10+
Bumps the actions group with 1 update: [pypa/gh-action-pypi-publish](https://github.com/pypa/gh-action-pypi-publish). Updates `pypa/gh-action-pypi-publish` from 1.11.0 to 1.12.2 - [Release notes](https://github.com/pypa/gh-action-pypi-publish/releases) - [Commits](pypa/gh-action-pypi-publish@v1.11.0...v1.12.2) --- updated-dependencies: - dependency-name: pypa/gh-action-pypi-publish dependency-type: direct:production update-type: version-update:semver-minor dependency-group: actions ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* ADD: Add ablog to docs using conda not pip Install ablog in the environment using conda * ADD: Add nbsphinx back in * Update environment.yml
Bumps the actions group with 1 update: [codecov/codecov-action](https://github.com/codecov/codecov-action). Updates `codecov/codecov-action` from 4.6.0 to 5.0.2 - [Release notes](https://github.com/codecov/codecov-action/releases) - [Changelog](https://github.com/codecov/codecov-action/blob/main/CHANGELOG.md) - [Commits](codecov/codecov-action@v4.6.0...v5.0.2) --- updated-dependencies: - dependency-name: codecov/codecov-action dependency-type: direct:production update-type: version-update:semver-major dependency-group: actions ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…we have a working version (#1696) * FIX: Update to use f-format strings. * STY: PEP8 fix. * FIX: Need int for correct struct fmt. Also forgot two 'f' pre quotes. * FIX: Last missing 'f'
Bumps the actions group with 2 updates: [codecov/codecov-action](https://github.com/codecov/codecov-action) and [pypa/cibuildwheel](https://github.com/pypa/cibuildwheel). Updates `codecov/codecov-action` from 5.0.2 to 5.0.7 - [Release notes](https://github.com/codecov/codecov-action/releases) - [Changelog](https://github.com/codecov/codecov-action/blob/main/CHANGELOG.md) - [Commits](codecov/codecov-action@v5.0.2...v5.0.7) Updates `pypa/cibuildwheel` from 2.21.3 to 2.22.0 - [Release notes](https://github.com/pypa/cibuildwheel/releases) - [Changelog](https://github.com/pypa/cibuildwheel/blob/main/docs/changelog.md) - [Commits](pypa/cibuildwheel@v2.21.3...v2.22.0) --- updated-dependencies: - dependency-name: codecov/codecov-action dependency-type: direct:production update-type: version-update:semver-patch dependency-group: actions - dependency-name: pypa/cibuildwheel dependency-type: direct:production update-type: version-update:semver-minor dependency-group: actions ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Max Grover <[email protected]>
* Set `nb` value for grid interpolation * Update email address * Update citations * Update qpe.py * Fix linting errors * Fix linting errors take 2 --------- Co-authored-by: Max Grover <[email protected]>
* Added script to calculate storm relative velocity * Added support for u and v components to SRV script * Added storm_relative_velocity to __init__.py * TST: Adding unit tests and PEP8 fixes to storm_relative_velocity fun. * STY: Don't lint import. * FIX: Add s3fs to environment. * FIX: Update to use lists. * FIX: Use almost_equal. --------- Co-authored-by: zssherman <[email protected]> Co-authored-by: Zach Sherman <[email protected]>
) Bumps the actions group with 1 update: [mamba-org/setup-micromamba](https://github.com/mamba-org/setup-micromamba). Updates `mamba-org/setup-micromamba` from 2.0.1 to 2.0.2 - [Release notes](https://github.com/mamba-org/setup-micromamba/releases) - [Commits](mamba-org/setup-micromamba@v2.0.1...v2.0.2) --- updated-dependencies: - dependency-name: mamba-org/setup-micromamba dependency-type: direct:production update-type: version-update:semver-patch dependency-group: actions ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* FIX: Fix the gallery build issue with new sphinx * ENH: Improve compatibility of xradar integration with cfradial2 * ADD: Add cfradial2 example * FIX: Fix change of nbsphinx * FIX: Fix the io portion of the cfradial2 examples * FIX: Fix the io portion of the cfradial2 examples
* FIX: Fix the gallery build issue with new sphinx * ADD: Add cvxopt default and test gatefilter
* FIX: Fix the gallery build issue with new sphinx * FIX: Fix the flag for the cvxopt flag
Bumps the actions group with 1 update: [codecov/codecov-action](https://github.com/codecov/codecov-action). Updates `codecov/codecov-action` from 5.0.7 to 5.1.1 - [Release notes](https://github.com/codecov/codecov-action/releases) - [Changelog](https://github.com/codecov/codecov-action/blob/main/CHANGELOG.md) - [Commits](codecov/codecov-action@v5.0.7...v5.1.1) --- updated-dependencies: - dependency-name: codecov/codecov-action dependency-type: direct:production update-type: version-update:semver-minor dependency-group: actions ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…ed by wavelength. (#1707) * FIX: Update sigmet reader to handle 1byte kdp, that needs to be divided by wavelength. * FIX: Weird style issues. * Update pyart/io/_sigmetfile.pyx * Update pyart/io/_sigmetfile.pyx * FIX: ANother style fix and doc fix possibly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bring in recent changes to main