-
Notifications
You must be signed in to change notification settings - Fork 270
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MNT: Remove pandas pinning, testing. #1430
Conversation
zssherman
commented
May 25, 2023
- Closes #xxxx
- Tests added
- Documentation reflects changes
@mgrover1 Do we know what the original issue was when we pinned pandas? Going to see if we can solve the issue or if it has resolved. Will respond back in a bit, heading to the dentist. |
It was due to some of the datetime handling with xarray - looks like it is still an issue. |
@mgrover1 Ah gotcha, so there's nothing we can do on our end? it seems to be specifically that comp z test file |
@mgrover1 Think I found a solution |
@mgrover1 Not entirely sure what the error is, some pydata sphinx extension error? |
@zssherman ablog had a new update - checking to see if they're recommendations for fixing help. |
@mgrover1 Looks good! I'll merge ahead |
The pin is causing failures in yt's CI (because pandas 1.5 uses API that's now deprecated in numpy 1.25). Any chance this would make it into a release soon ? We can work around it on our side otherwise, just let us know ! :-) |
We can cut a release tomorrow! 😃 |
@neutrinoceros The new release should be out now! I apologize for the late ping. |
On the contrary, thank you very much for your reactivity ! |