Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MNT: Remove pandas pinning, testing. #1430

Merged
merged 8 commits into from
Jun 7, 2023

Conversation

zssherman
Copy link
Collaborator

  • Closes #xxxx
  • Tests added
  • Documentation reflects changes

@zssherman
Copy link
Collaborator Author

@mgrover1 Do we know what the original issue was when we pinned pandas? Going to see if we can solve the issue or if it has resolved. Will respond back in a bit, heading to the dentist.

@mgrover1
Copy link
Collaborator

@mgrover1 Do we know what the original issue was when we pinned pandas? Going to see if we can solve the issue or if it has resolved. Will respond back in a bit, heading to the dentist.

It was due to some of the datetime handling with xarray - looks like it is still an issue.

@zssherman
Copy link
Collaborator Author

@mgrover1 Ah gotcha, so there's nothing we can do on our end? it seems to be specifically that comp z test file

@zssherman
Copy link
Collaborator Author

@mgrover1 Think I found a solution

@zssherman
Copy link
Collaborator Author

@mgrover1 Not entirely sure what the error is, some pydata sphinx extension error?

@mgrover1
Copy link
Collaborator

@zssherman ablog had a new update - checking to see if they're recommendations for fixing help.

@zssherman
Copy link
Collaborator Author

@mgrover1 Looks good! I'll merge ahead

@neutrinoceros
Copy link
Contributor

The pin is causing failures in yt's CI (because pandas 1.5 uses API that's now deprecated in numpy 1.25). Any chance this would make it into a release soon ? We can work around it on our side otherwise, just let us know ! :-)

@mgrover1
Copy link
Collaborator

We can cut a release tomorrow! 😃

@zssherman
Copy link
Collaborator Author

@neutrinoceros The new release should be out now! I apologize for the late ping.

@neutrinoceros
Copy link
Contributor

On the contrary, thank you very much for your reactivity !

@zssherman zssherman deleted the remove_pandas_pin branch January 23, 2024 19:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants