drop pkg_resources as a runtime requirement #1394
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I see that ruff+pyupgrade is targeting Python 3.9+, so let's just run with it |
neutrinoceros
force-pushed
the
no_pkg_resources
branch
2 times, most recently
from
22d96eb to
980d99c
Compare
neutrinoceros
force-pushed
the
no_pkg_resources
branch
from
980d99c to
6cccde2
Compare
|
@neutrinoceros Thank you for the pull request! I think at this point we are trying to follow conda-forge etc on current testing and releases. So usually the 3 newest python versions I think or whichever it is. I'll let @mgrover1 provide some input as well. But with that being said, this PR looks good to me! I think yeah we need to have a more universal Python standard for versions between things. Yeah the classifiers looked to be out of date, so the fix for that in this PR looks good! But I'll check the wheel build as well. |
zssherman
approved these changes
Mar 6, 2023
mgrover1
approved these changes
Mar 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pkg_resourcesis deprecated https://setuptools.pypa.io/en/latest/history.html#v67-5-0Note to reviewers: it's not perfectly clear to me which versions of Python are still supported as various sources differ:
Are the classifiers are just out of date ? I did the maximal effort to keep compatibility with Python<3.8 here, but if 3.9 is already the minimal supported version this PR can be simplified.