Add pre-commit hooks, black formatting, and style fixes #1341
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
|
These are the remaining code styling issues: Hoping to finish this up this week. |
mgrover1
force-pushed
the
add-pre-commit-hooks-black-formatting
branch
from
2e42f93 to
cce5fb7
Compare
|
Home stretch... these are the remaining updates required |
|
@mgrover1 Good work on this! I'll take a look, might take a bit with 230 files haha, but I'll get a review going |
|
Great - thanks! Yeah... no worries about it taking a bit |
zssherman
reviewed
Dec 22, 2022
zssherman
reviewed
Dec 22, 2022
| - pip: | ||
| - wheel | ||
| - watchdog | ||
| - flake8 |
There was a problem hiding this comment.
Do we want all of these in our user environment file?
There was a problem hiding this comment.
Yeah, if people are going to be developing with this, I think they should be? They are relatively straight forward packages to install (and well supported)
There was a problem hiding this comment.
@mgrover1 I would say maybe a base environment.yml for users and an environment_dev.yml, for those who want more.
coverage, twine, sphinx etc I doubt a user will use, maybe pytest.
zssherman
reviewed
Dec 22, 2022
|
Alrighty thanks for the comments so far @zssherman - I made those suggested changes! |
zssherman
reviewed
Dec 22, 2022
| - pip: | ||
| - wheel | ||
| - watchdog | ||
| - flake8 |
There was a problem hiding this comment.
@mgrover1 I would say maybe a base environment.yml for users and an environment_dev.yml, for those who want more.
coverage, twine, sphinx etc I doubt a user will use, maybe pytest.
|
@zssherman I think its worth keeping it more simple, with everything in the The packages included here are pretty well maintained |
|
@mgrover1 Sounds good, reverted environment files. |
|
This looks good to me! |
|
@zssherman should we go ahead and merge? |
|
@mgrover1 Yeah I think this is good to go! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This make sure our code is style-compliant, and adds tools to help with this.