Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ADD: Adding add_filter function to radar.py. #1326

Merged
merged 4 commits into from
Nov 15, 2022

Conversation

zssherman
Copy link
Collaborator

@zssherman zssherman commented Nov 14, 2022

This function applies a filter to fields and either replaces or adds new filtered fields.

Note, adding tests to this PR, just initial review.

Closes, #763

This function applies a filter to fields and either replaces
or addeds new filtered fields.
Copy link
Collaborator

@mgrover1 mgrover1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One minor comment - otherwise, this looks great!

pyart/core/radar.py Show resolved Hide resolved
@zssherman
Copy link
Collaborator Author

@mgrover1 Added unit tests as well now for review.

Copy link
Collaborator

@mgrover1 mgrover1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great! Good work @zssherman

@zssherman zssherman merged commit 4b38cb0 into ARM-DOE:main Nov 15, 2022
@zssherman zssherman deleted the add_filter branch November 15, 2022 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants