ENH: Improved convective stratiform functions #1314
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rcjackson
suggested changes
Nov 8, 2022
mgrover1
requested changes
Nov 8, 2022
mgrover1
reviewed
Nov 9, 2022
mgrover1
reviewed
Nov 9, 2022
|
@lauratomkins - I think with a couple minor changes to the name of the function in the tests/example, the tests should pass. |
mgrover1
reviewed
Nov 9, 2022
|
@lauratomkins two more spots in the tests - it looks like the last commit fixed it on the docs side! So close! |
mgrover1
changed the title
Co-authored-by: Max Grover <[email protected]>
mgrover1
reviewed
Nov 9, 2022
mgrover1
approved these changes
Nov 9, 2022
There was a problem hiding this comment.
This all looks great - thanks for making all those changes @lauratomkins ! @rcjackson / @zssherman can you give this another look?
|
@mgrover1 sweet! On my back from lunch then I can take a look! |
|
@zssherman did you still want to take a look? Otherwise, we can go ahead and merge! Great work @lauratomkins !! |
|
Looks good to me! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have updated the original convective stratiform functions from Steiner et al. (1995) to include enhancements from Yuter and Houze (1997) and Yuter et al. (2005). The current convective stratiform functions are slow and not easily modified. The new enhancements use the
scipypackage to make some of the steps significantly faster. The new functions also include many new parameters that can be adjusted for different applications. I have also included an example file that describes the steps of the convective stratiform algorithm, explains the parameters used, and shows several examples.Any feedback would be greatly appreciated! I've spent a lot of time testing all the different functions so they work as intended. Hoping this can be an easy addition but happy to provide extra information to improve the workflow.