Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plot grid modif #1311

Merged
merged 4 commits into from
Nov 3, 2022
Merged

Plot grid modif #1311

merged 4 commits into from
Nov 3, 2022

Conversation

jfigui
Copy link
Contributor

@jfigui jfigui commented Nov 3, 2022

Closes #1297.
Added keyword add_lines in plot_grid in gridmapdisplay.py and plot_ppi_map in radarmapdisplay.py.
General linting of gridmapdisplay and radarmapdisplay.

Copy link
Collaborator

@mgrover1 mgrover1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small suggestion... other than that, this looks great! Thanks @jfigui

pyart/graph/gridmapdisplay.py Outdated Show resolved Hide resolved
pyart/graph/radarmapdisplay.py Outdated Show resolved Hide resolved
Copy link
Collaborator

@zssherman zssherman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me with the changes, and thanks for the PEP8 changes etc as well!

Copy link
Collaborator

@mgrover1 mgrover1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to merge!

@mgrover1 mgrover1 merged commit 83d0cdb into ARM-DOE:main Nov 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ENH: Add keyword add_lines in method plot_grid in gridmapdisplay
3 participants