Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ADD: Add AWS NEXRAD example in new IO section #1117

Merged
merged 6 commits into from
Apr 19, 2022

Conversation

mgrover1
Copy link
Collaborator

Here, we add a new example showing how to read NEXRAD Level 2/3 data remotely from AWS

@mgrover1 mgrover1 requested a review from zssherman April 19, 2022 19:42
@zssherman
Copy link
Collaborator

These dependencies for this example are they planned on only being used for this example? Or will they be added to py-art in the future? Trying to think about optional dependencies etc

@mgrover1
Copy link
Collaborator Author

we could consider adding them... both are well maintained + would be super useful to the community

@mgrover1
Copy link
Collaborator Author

We could consider just adding s3fs for now?

@zssherman
Copy link
Collaborator

If they are both well maintained etc, should be fine.

@zssherman
Copy link
Collaborator

Error looks to be something with boto and possibly s3fs and authorization.

@mgrover1
Copy link
Collaborator Author

Yeah - I think we need to add another argument to that reader - storage_options

#
# For example, we can look at data from that same time as the NEXRAD Level 2 data used previously (March 22, 2022 at 1201 UTC)

aws_nexrad_level3_velocity_file = "s3://unidata-nexrad-level3/HGX_N0U_2022_03_22_12_01_25"

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@zssherman
Copy link
Collaborator

@mgrover1 Was there a reason for removing the getting help section?

Input/Output Examples
--------------------------

Reading/writing a vareity of radar data using Py-ART.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

vareity to variety

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mgrover1 Was there a reason for removing the getting help section?

Yeah - I think it would be helpful to have a dedicated page.. for now, I removed it since the GitHub button takes you to a similar spot, but open to suggestions. I am thinking we could have a Getting Help Page that summarizes the two main options:

  • The email list
  • Github Discussions (which would be preferred)

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That makes sense to me!

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But yeah - for now, I think it makes sense to remove the link to issues. I can open a separate issues highlighting the that proposed getting help page

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changing this now

@mgrover1
Copy link
Collaborator Author

@zssherman should be good to go now

@zssherman zssherman merged commit bf79eaa into ARM-DOE:main Apr 19, 2022
@mgrover1 mgrover1 deleted the add-aws-nexrad-example branch March 8, 2023 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants