-
Notifications
You must be signed in to change notification settings - Fork 271
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ADD: Time tolerance to GateMapper #1093
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Small name change
pyart/map/gate_mapper.py
Outdated
@@ -50,32 +50,43 @@ class GateMapper(object): | |||
The gatefilter to apply to the source radar data before mapping | |||
tol: float | |||
The difference in meters between the source and destination gate allowed for an adequate match. | |||
time_tol: float |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you rename both tol
/time_tol
here? Changing it to distance_tolerance
, and time_tolerance
so it is a bit more explicit?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've put in a new commit changing the names of these two variables to be more explicit throughout.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome - the example will need an update too... which is why the doc build is failing
@rcjackson just a couple of suggestions in terms of naming... I think this will make it clearer for people using this API |
@rcjackson I added the example doc update here since the api changed slightly |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Alrighty! This looks good to go 👍
Added a time tolerance to the GateMapper function. Now you can exclude points that are out of synchronization when doing gate to gate comparisons.