ADD: Gatefilter to GateMapper. #1077
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@rcjackson just let me know when this is ready for a review! |
|
It already is. :) |
mgrover1
approved these changes
Mar 16, 2022
There was a problem hiding this comment.
Great! Thanks @rcjackson - I think this will be super useful, and I like the use of variable names/the test you included. Good to go!
|
Waiting to see how the tests go! |
|
Merging! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GateMapper now supports a GateFilter. I've also added some more documentation for GateFilter and also provided a setter for tolerance that will reset the internal KD-Tree if the tolerance variable is changed.