Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix non-example building #1051

Merged
merged 9 commits into from
Mar 4, 2022
Merged

Fix non-example building #1051

merged 9 commits into from
Mar 4, 2022

Conversation

mgrover1
Copy link
Collaborator

@mgrover1 mgrover1 commented Mar 4, 2022

There was still a flag in the conf.py directory preventing the examples to be built - this fixes that section

zssherman
zssherman approved these changes Mar 4, 2022
View reviewed changes
Copy link
Collaborator

@zssherman zssherman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, not sure why the tests is failing however.

@mgrover1
Copy link
Collaborator Author

mgrover1 commented Mar 4, 2022

@zssherman still trying to figure out why the docs build is failing...

@zssherman
Copy link
Collaborator

@mgrover1 error is solver define should be LP_solver

@mgrover1
Copy link
Collaborator Author

mgrover1 commented Mar 4, 2022 •
edited
Loading

Alrighty @zssherman ! Good to merge!

@mgrover1 mgrover1 merged commit b666be3 into ARM-DOE:main Mar 4, 2022
@mgrover1 mgrover1 deleted the fix_missing_examples branch March 4, 2022 16:54
@mgrover1 mgrover1 added the Docs label Mar 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zssherman zssherman zssherman approved these changes

Assignees
No one assigned
Labels
Docs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mgrover1 @zssherman