Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding step detection test #889

Merged
merged 3 commits into from
Dec 11, 2024
Merged

Adding step detection test #889

merged 3 commits into from
Dec 11, 2024

Conversation

kenkehoe
Copy link
Contributor

This is adding a new test to check for shift in data values. I have also included an example in the examples directory with a plot.

  • [ X] Tests added
  • [X ] Documentation reflects changes
  • [X ] PEP8 Standards or use of linter
  • [X ] Xarray Dataset or DataArray variable naming follows 'ds' or 'da' naming

zssherman
zssherman reviewed Dec 11, 2024
View reviewed changes
act/qc/qctests.py Outdated Show resolved Hide resolved
zssherman
zssherman reviewed Dec 11, 2024
View reviewed changes
act/qc/qctests.py Outdated Show resolved Hide resolved
zssherman
zssherman reviewed Dec 11, 2024
View reviewed changes
tests/qc/test_qctests.py Outdated Show resolved Hide resolved
zssherman
zssherman reviewed Dec 11, 2024
View reviewed changes
tests/qc/test_qctests.py Outdated Show resolved Hide resolved
zssherman
zssherman reviewed Dec 11, 2024
View reviewed changes
tests/qc/test_qctests.py Outdated Show resolved Hide resolved
zssherman
zssherman reviewed Dec 11, 2024
View reviewed changes
tests/qc/test_qctests.py Outdated Show resolved Hide resolved
zssherman
zssherman reviewed Dec 11, 2024
View reviewed changes
tests/qc/test_qctests.py Outdated Show resolved Hide resolved
zssherman
zssherman requested changes Dec 11, 2024
View reviewed changes
Copy link
Collaborator

@zssherman zssherman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some comments for some spelling changes and one question as well.

@zssherman
Copy link
Collaborator

@kenkehoe Thanks for making those changes! Merging.

@zssherman zssherman merged commit 2a6e1f8 into ARM-DOE:main Dec 11, 2024
18 of 19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zssherman zssherman zssherman approved these changes

@AdamTheisen AdamTheisen Awaiting requested review from AdamTheisen AdamTheisen is a code owner

@mgrover1 mgrover1 Awaiting requested review from mgrover1 mgrover1 is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kenkehoe @zssherman