Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ADD: Adding new function to validate that a file or DataSet meet ARM … #849

Merged
merged 4 commits into from
Aug 12, 2024
Merged

ADD: Adding new function to validate that a file or DataSet meet ARM … #849

merged 4 commits into from
Aug 12, 2024

Conversation

AdamTheisen
Copy link
Collaborator

@AdamTheisen AdamTheisen commented Aug 12, 2024 •
edited
Loading

…standards

  • Closes #xxxx
  • Tests added
  • Documentation reflects changes
  • PEP8 Standards or use of linter
  • Xarray Dataset or DataArray variable naming follows 'ds' or 'da' naming

@AdamTheisen
Copy link
Collaborator Author

Going to add in one more test here

zssherman
zssherman reviewed Aug 12, 2024
View reviewed changes
@AdamTheisen
Copy link
Collaborator Author

@zssherman anything else you noticed or are we good to merge in?

@zssherman
Copy link
Collaborator

Looks good to me @AdamTheisen ! Merging.

@zssherman zssherman merged commit c20753b into ARM-DOE:main Aug 12, 2024
19 checks passed
@AdamTheisen AdamTheisen deleted the adv branch August 12, 2024 17:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zssherman zssherman zssherman approved these changes

@mgrover1 mgrover1 Awaiting requested review from mgrover1 mgrover1 is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AdamTheisen @zssherman