Getting correct length of MPG movie. #832
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… step of the movie is more than 0.1 then there can be multiple images that are the same. Checking multiple images being the same is how to determine the end of the movie. This fix allows some fudge factor by checking for multiple repeating images to signify the end.
kenkehoe
requested review from
AdamTheisen,
zssherman and
mgrover1
as code owners
zssherman
approved these changes
May 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is an issue guessing the duration of the MPG movie when converting to another file type. If the time step of the movie is more than 0.1 then there can be multiple images that are the same. Checking multiple images being the same is how to determine the end of the movie. This fix allows some fudge factor by checking for multiple repeating images to signify the end.