ENH: Napoleon #180
Merged
ENH: Napoleon #180
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Napoleon overall is cleaner and its a sphinx extension, so removed need for numpydoc.
|
Thanks for all this work @zssherman! Pinging @kenkehoe as well so that he's aware of the document updates. |
AdamTheisen
approved these changes
Feb 4, 2020
|
Awesome thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A nice version of numpy docs, removes the need for numpy doc extension as napoleon is built in with sphinx. This will fix the colon issue, and with the docs, I will add more commits to this pull request for the colon spacing. Overall cleaner docs. Down the road can invest in autosummary templates for modules, classes, and base so there would no longer be a need for rsts for all modules and submodules, just an index.rst